Agreed - there seems to be a ton being dumped into the contrail plugin. If it wasn't working by feature freeze then we should wait. If all of these are bugfixes, I'd expect to see more bugs filed and referenced in commits, but instead have been seeing commits that seem to expand the functionality of the plugin.
--David On Thu, Jan 16, 2014 at 2:01 PM, Hugo Trippaers <htrippa...@schubergphilis.com> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16974/#review32050 > ----------------------------------------------------------- > > > Are these fixes release blockers or can they go into 4.4? The release 4.3 is > effectively closed by now. > > Cheers, > > Hugo > > - Hugo Trippaers > > > On Jan. 16, 2014, 6:53 p.m., Sachchidanand Vaidya wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/16974/ >> ----------------------------------------------------------- >> >> (Updated Jan. 16, 2014, 6:53 p.m.) >> >> >> Review request for cloudstack. >> >> >> Repository: cloudstack-git >> >> >> Description >> ------- >> >> These are additional fixes to make Juniper Contrail plugin work in ACS4.3. >> These changes were missed during last commit >> >> >> Diffs >> ----- >> >> plugins/network-elements/juniper-contrail/pom.xml 22167fe >> >> plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/module.properties >> PRE-CREATION >> >> plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml >> PRE-CREATION >> >> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java >> 18e8bde >> >> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java >> 6587534 >> >> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java >> 82f2cc4 >> >> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java >> dec4a9e >> >> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java >> 195e932 >> plugins/network-elements/juniper-contrail/test/resources/commonContext.xml >> c577513 >> >> Diff: https://reviews.apache.org/r/16974/diff/ >> >> >> Testing >> ------- >> >> Locally tested on centOS6.3 machine. >> >> >> Thanks, >> >> Sachchidanand Vaidya >> >> >
