> -----Original Message----- > From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers > Sent: 15 January 2014 20:26 > To: SuichII, Christopher > Cc: Hugo Trippaers; dev; sate...@apache.org > Subject: Re: The commit ba96c8cadfa4b1dc7ee74fdb26ba5cea87e29b91 breaks a > clean installation > > Done!
Thanks Hugo for fixing this. Sorry for the inconvenience caused. Couldn't catch this during my upgrade test as this script didn't kick in due to stale 4.3 database. Regards, Sateesh > > Cheers, > > Hugo > > > On 15 jan. 2014, at 15:26, SuichII, Christopher <chris.su...@netapp.com> > wrote: > > > Can you apply this to the 4.3 branch as well, please? > > > > -Chris > > -- > > Chris Suich > > chris.su...@netapp.com > > NetApp Software Engineer > > Data Center Platforms - Cloud Solutions > > Citrix, Cisco & Red Hat > > > > On Jan 15, 2014, at 9:22 AM, Hugo Trippaers <h...@trippaers.nl> wrote: > > > >> Should be fixed: > >> > >> commit 9aaea28d0dedc370888d346d55c81b95486f131b > >> Author: Hugo Trippaers <htrippa...@schubergphilis.com> > >> Date: Wed Jan 15 15:20:48 2014 +0100 > >> > >> Fix typo > >> > >> diff --git a/engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java > b/engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java > >> index bf08e87..9702792 100644 > >> --- a/engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java > >> +++ b/engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java > >> @@ -80,7 +80,7 @@ public class Upgrade421to430 implements DbUpgrade { > >> > >> try { > >> selectPstmt = conn.prepareStatement("SELECT id FROM > >> `cloud`.`service_offering` WHERE vm_type='secondarystoragevm'"); > >> - updatePstmt = conn.prepareStatement("UPDATE > >> `cloud`.`service_offering` SET ram_size=? WHERE id=?'"); > >> + updatePstmt = conn.prepareStatement("UPDATE > >> `cloud`.`service_offering` SET ram_size=? WHERE id=?"); > >> selectResultSet = selectPstmt.executeQuery(); > >> if(selectResultSet.next()) { > >> serviceOfferingId = selectResultSet.getLong("id"); > >> > >> > >> > >> On 15 jan. 2014, at 15:17, Hugo Trippaers <trip...@gmail.com> wrote: > >> > >>> Sateesh, > >>> > >>> The commit ba96c8cadfa4b1dc7ee74fdb26ba5cea87e29b91 breaks a clean > >>> installation of CloudStack at the moment. The error is this: > >>> > >>> 2014-01-15 15:07:19,166 ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) > >>> Unable to upgrade the database > >>> com.cloud.utils.exception.CloudRuntimeException: Unable to upgrade > >>> ram_size of service offering for secondary storage v > >>> m. > >>> at > >>> com.cloud.upgrade.dao.Upgrade421to430.upgradeMemoryOfSsvmOffering(Upgrade421to430.java:93) > >>> at > >>> com.cloud.upgrade.dao.Upgrade421to430.performDataMigration(Upgrade421to430.java:66) > >>> at > >>> com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:310) > >>> at > >>> com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:432) > >>> at > >>> org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.checkIntegrity(CloudStackExtendedLifeCycl > >>> e.java:65) > >>> > >>> You can reproduce it by using cloudstack-setup-database to configure the > >>> database and then starting the management server. > >>> > >>> > >>> Cheers, > >>> > >>> Hugo > >> > >