> On Jan. 17, 2014, 6:06 a.m., Murali Reddy wrote: > > changes look good, patch does not apply on master. Can you please resubmit. > > > > Also please see if the patch applies on 4.2, when you resubmit.
Murali, Added patch for master - it does not apply on 4.2. Code change enough that it won't apply cleanly. The changes are almost identical except for a few things. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16249/#review32129 ----------------------------------------------------------- On Jan. 22, 2014, 2:07 p.m., David Grizzanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16249/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 2:07 p.m.) > > > Review request for cloudstack and Murali Reddy. > > > Bugs: CLOUDSTACK-5496 > https://issues.apache.org/jira/browse/CLOUDSTACK-5496 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-5496 : Account included in ActionEvents is Project Account ID > > When Action Events are generated and placed on the Event Bus, an "account" > parameter is included with the event. When these events are generated for > resources within projects, this "account" parameter is not useful as it's the > UUID of the project account, instead of the project. > > To solve this, I updated ActionEventsUtil class to include a "project" > parameter in the generated events when the resource is being > changed/add/deleted in a project. > > > Diffs > ----- > > server/src/com/cloud/event/ActionEventUtils.java 0363a0d > server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 061fd42 > > Diff: https://reviews.apache.org/r/16249/diff/ > > > Testing > ------- > > Testing done 4.2 > > > Thanks, > > David Grizzanti > >
