----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review32472 -----------------------------------------------------------
Can you please run marvin test cases of VPC with this patch and update the testing done section - Jayapal Reddy On Jan. 7, 2014, 11:58 a.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14124/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2014, 11:58 a.m.) > > > Review request for cloudstack, Jayapal Reddy and Sateesh Chodapuneedi. > > > Bugs: CLOUDSTACK-4622 > https://issues.apache.org/jira/browse/CLOUDSTACK-4622 > > > Repository: cloudstack-git > > > Description > ------- > > Add a new utility method for comparing 2 CIDRs. > The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP > range is equal or a subset of cidrB's IP range. > > > Diffs > ----- > > utils/src/com/cloud/utils/net/NetUtils.java 266a5d1 > utils/test/com/cloud/utils/net/NetUtilsTest.java b049516 > > Diff: https://reviews.apache.org/r/14124/diff/ > > > Testing > ------- > > Added unit test for the utility. > Tested locally. > Build is successful. > Patch applies cleanly. > > > Thanks, > > Saksham Srivastava > >
