Hi, Fixed the issues highlighted in the ldap user authentication package.
Have pushed to 4.3-forward. Thanks, Ian On 25 January 2014 22:26, Daan Hoogland <daan.hoogl...@gmail.com> wrote: > > or reply to this mail with the filename you are working on > I'll be looking at the server package as it seems to contain the most > issues. > > On Sat, Jan 25, 2014 at 4:00 PM, Hugo Trippaers <h...@trippaers.nl> wrote: > > I’ve also added a job to master with the Findbugs report and the > cobertura code coverage report. > > > > Good stuff, we have a 12% coverage of our classes with unit tests. Huge > improvement over the last release where we had 4% iirc. We have 306 reports > from Findbugs, of which the majority are internationalization issues. > (String.getBytes without charset mostly). On the coverity site we have > 6000+ issues still open, but at least that number is relatively stable, we > fix as much issues as we introduce and it’s untuned so we can assume a > large number of false positives there. > > > > I think that on average the automated tools tell us that code quality is > improving, which a good thing. Combined with the functional testing and the > simulator build we can prove that we are doing quite well on the code > quality angle. > > > > http://jenkins.buildacloud.org/job/build-master-slowbuild/ > > > > > > Cheers, > > > > Hugo > > > > > > On 25 jan. 2014, at 14:13, Daan Hoogland <daan.hoogl...@gmail.com> > wrote: > > > >> H Hugo, > >> > >> I'll spend some time on it tonight. Do you have a work load > >> distribution scheme or is it random access? > >> ;) > >> > >> regards > >> > >> On Sat, Jan 25, 2014 at 12:39 PM, Hugo Trippaers <h...@trippaers.nl> > wrote: > >>> Hey all, > >>> > >>> I've made Jenkins run the findbugs analysis on 4.3-forward. Is there > somebody who is willing to help triage the findings? Maybe there is some > stuff that we need to fix? > >>> > >>> the url is > http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/3/findbugsResult/ > >>> > >>> Cheers, > >>> > >>> Hugo > > >
