Hey guys, I only saw this thread just now. I have reverted the change in 4.3-forward and redid only the highest prio-parts in separate commits.
@Animesh you should have a mail wiith the list of new commits @Alena I'll revisit the part in UserVmJoinVO to see what if anything is needed to satisfy the findbugs issue. but I am at the moment only looking at the 'scariest' category which I think this one is not part of. my apologies for not catching this thread, Daan On Thu, Jan 30, 2014 at 8:34 PM, Animesh Chaturvedi <animesh.chaturv...@citrix.com> wrote: > > -----Original Message----- > From: Alena Prokharchyk > Sent: Thursday, January 30, 2014 11:20 AM > To: Animesh Chaturvedi; dev@cloudstack.apache.org > Cc: daan.hoogl...@gmail.com > Subject: Re: userVmResponse no longer returns some parameters > > No. This particular commit has changes in may files, and changes are so > random, so its hard to say the purpose of each. > I would advise to: > > 1) revert the commit altogether > Animesh> I will revert the commit in an hour unless I hear objections. Daan I > think #2, #3 seems reasonable. > > 2) Split changes into several separate commits based on purpose > 3) Define clear purpose in the commit description before pushing it to the > repo. > > > -Alena. > > On 1/30/14, 11:16 AM, "Animesh Chaturvedi" <animesh.chaturv...@citrix.com> > wrote: > >>Alena >> >>Is the offending change restricted to this file only >> >>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=s >>erv >>er/src/com/cloud/api/query/vo/UserVmJoinVO.java;h=2bb0783595e7f6b5957cb >>945 >>88a3cdd035baff55;hp=25079ca59f5d0ce0dabffcccb0b05972ea9e7a35;hb=dcda79e >>2c0 >>2fda4e0fe52f61bf61712742e1f0db;hpb=1fb32b58eb76d0c963bee7cc238d0f37a6dd >>839 >>3 >> >> >> >>Animesh >> >>-----Original Message----- >>From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] >>Sent: Thursday, January 30, 2014 7:44 AM >>To: dev@cloudstack.apache.org >>Cc: daan.hoogl...@gmail.com >>Subject: Re: userVmResponse no longer returns some parameters >> >>Daan >> >>Did you review this thread? >> >>Thanks >>Animesh >> >>On Jan 29, 2014, at 3:50 PM, "Animesh Chaturvedi" >><animesh.chaturv...@citrix.com> wrote: >> >>> Daan >>> >>> This is from the recent commit that you cherry-picked into 4.3. These >>> unintended consequences was my reason not to change so late. Anyhow >>> please review >>> >>> Animesh >>> >>> -----Original Message----- >>> From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com] >>> Sent: Wednesday, January 29, 2014 2:32 PM >>> To: dev@cloudstack.apache.org >>> Cc: Daan Hoogland >>> Subject: Re: userVmResponse no longer returns some parameters >>> >>> dcda79e2c02fda4e0fe52f61bf61712742e1f0db >>> >>> On 1/29/14, 2:22 PM, "Animesh Chaturvedi" >>> <animesh.chaturv...@citrix.com> >>> wrote: >>> >>>> Alena do you know the commit ID >>>> >>>> -----Original Message----- >>>> From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com] >>>> Sent: Wednesday, January 29, 2014 2:03 PM >>>> To: dev@cloudstack.apache.org >>>> Cc: Daan Hoogland >>>> Subject: Re: userVmResponse no longer returns some parameters >>>> >>>> So the problem exists in 4.3 branch as well? >>>> >>>> =alena. >>>> >>>> On 1/29/14, 1:59 PM, "Sheng Yang" <sh...@yasker.org> wrote: >>>> >>>>> That's the reason of: >>>>> http://www.mail-archive.com/dev@cloudstack.apache.org/msg21948.html >>>>> >>>>> --Sheng >>>>> >>>>> >>>>> On Wed, Jan 29, 2014 at 1:53 PM, Alena Prokharchyk < >>>>> alena.prokharc...@citrix.com> wrote: >>>>> >>>>>> Hi Daan, >>>>>> >>>>>> In the latest master build I observed that listVirtualMachines >>>>>> command no longer returns parameters like: >>>>>> >>>>>> State >>>>>> displayName >>>>>> Account >>>>>> >>>>>> Its due to the commit that you've cherry-picked >>>>>> (fae05560218ef3bcb962bd424ae5dbf5cb8ede68) >>>>>> >>>>>> Setting corresponding fields in UserVmJoinVO to become final, >>>>>> causing them to always return NULL in the response. >>>>>> >>>>>> Can you please fix it? Current behavior will break all integration >>>>>> code. >>>>>> >>>>>> Thanks, >>>>>> Alena. >>> >
