----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17335/ -----------------------------------------------------------
(Updated Feb. 2, 2014, 5:03 p.m.) Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min Chen. Changes ------- Added Alena Prokharchyk API component owner as reviewer Repository: cloudstack-git Description ------- - changed type parameters on details map in CreateSecondaryStagingStoreCmd - <String, String> was misleading since the it can not work with a string value and it is never a string - introducing the type parameters allowed some simplifications in getDetails() - added unit test Diffs ----- api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java 1480e75 api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java PRE-CREATION Diff: https://reviews.apache.org/r/17335/diff/ Testing ------- - all unit tests passed - checked all references and usage of the details field, injection with the @Parameter annotation Thanks, Laszlo Hornyak
