----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review34062 -----------------------------------------------------------
On high instance count cluster hosts (in clusters based on XS6.2) a max of 16 would reduce the allowed instances on such a host. I would like to suggest, in addition to the current proposition, make dynamic scaling configurable on a compute offering. When DS has been disabled instances based on that service offering will get vCPUMAX=vCPU. The same goes for system offerings. If this suggestion is not desirable I would like to suggest to only implement for system offerings. - Joris van Lieshout On Feb. 7, 2014, 11:19 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17747/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 11:19 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin > Mehta. > > > Bugs: CLOUDSTACK-6023 > https://issues.apache.org/jira/browse/CLOUDSTACK-6023 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6023: Non windows instances are created on XenServer with a > vcpu-max above supported xenserver limits > > Changed the VCPU max limit to 16 and provided a cluster level configuration > parameter for this max limit named xen.vm.vcpu.max > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/VirtualMachineTO.java e6240ff > plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 28bd724 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > 48ccf70 > > Diff: https://reviews.apache.org/r/17747/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > >