----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17900/#review34267 -----------------------------------------------------------
Ship it! Committed to master and 4.3-forward - Girish Shilamkar On Feb. 10, 2014, 2:48 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17900/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2014, 2:48 p.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-6066 > https://issues.apache.org/jira/browse/CLOUDSTACK-6066 > > > Repository: cloudstack-git > > > Description > ------- > > Changes: > 1) Improved migration code according to the hypervisor type. > For KVM, two hosts in the same cluster should be chosen for migration because > live migration is not possible between two hosts belonging to different > cluster. > In Xen and VMware, it is supported with XenMotion and Vmotion respectively. > > 2) Skipped test if two suitable hosts are not found instead of failing with > assertion error. > > 3) Whitespaces removed, changed the imports to only specific ones instead of * > > > Diffs > ----- > > test/integration/smoke/test_vm_life_cycle.py ff37c99 > > Diff: https://reviews.apache.org/r/17900/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Gaurav Aradhye > >
