> On Feb. 15, 2014, 12:53 p.m., Hugo Trippaers wrote: > > Heya, did you test this with devcloud as well?
Unfortunately not. I got the link error when trying it in my environment over my network. Will try to refresh the mac addresses on the net adapters in virtualbox VMs and see if it works. usually I have this link problem when the 2 machines (management server and devcloud) are executed from home. - Wilder ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18165/#review34568 ----------------------------------------------------------- On Feb. 15, 2014, 12:42 p.m., Wilder Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18165/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2014, 12:42 p.m.) > > > Review request for cloudstack, daan Hoogland and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Fixed 2 equals() method implementations > Added synchronized keyword to a get() method, because the set() is already > synchronized > Commented out a dead variable > > > Diffs > ----- > > engine/orchestration/src/com/cloud/agent/manager/AgentAttache.java 3ebaf4a > engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentAttache.java > 23c3f76 > engine/orchestration/src/com/cloud/agent/manager/ConnectedAgentAttache.java > 00d54bb > > engine/orchestration/src/org/apache/cloudstack/engine/service/api/ProvisioningServiceImpl.java > 86eab58 > > engine/orchestration/test/com/cloud/agent/manager/ConnectedAgentAttacheTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/18165/diff/ > > > Testing > ------- > > Check style successfully executed; > Build successfully executed > 5 unit tests added in order to cover the changes. > > > Thanks, > > Wilder Rodrigues > >
