I don't understand why it's a blocker for release. 1. There is no correlated BUG ID. 2. Unit test is good, but unit test is not a blocker for release. 3. If what's missing is only a check for input value, I don't think it's a blocker.
--Sheng On Tue, Feb 18, 2014 at 10:06 AM, Animesh Chaturvedi < animesh.chaturv...@citrix.com> wrote: > Daan > > Sorry I missed it. what is the impact of not including the fix? Is it > really a blocker? > > > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=d38a50343130f6f147e2c9c7b2e32a43f31c7e6b > > > Thanks > Animesh > > > -----Original Message----- > > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > > Sent: Tuesday, February 18, 2014 4:26 AM > > To: dev > > Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fifth round) > > > > -1 (binding) > > > > tested vlan based standalone network > > tested vlan based bridged network > > tested vpc with vlan based gateway and - tier network tested vpc with > nicira > > based gateway and - tier network > > > > All tests included creation of an instance and pinging the router from > the > > instance. > > > > All tests passed in the end but a note on the side is that all vlan > based tests > > didn't pass the ping test first time around. interface were created with > no ip > > and after manually assigning ips, the routers still couldn't be pinged, > > > > For no obvious reason they passed after destroying the network and > > recreating it. This worries me but will lead to a +0 as such. I can not > yet point > > to a bug that causes this. > > > > My -1 is due to another issue: a fix submitted to the 4.3-forward branch > > wasn't cherry-picked to this rc. See my earlier mail [1]. I had assumed > it > > would be included due to [2]. > > > > [1] http://markmail.org/message/sujzvfefxsohurt5 > > [2] http://markmail.org/message/n2q46ovlkvgyunyk > > > > kind regards, > > Daan Hoogland > > > > On Tue, Feb 18, 2014 at 7:07 AM, Srikanteswararao Talluri > > <srikanteswararao.tall...@citrix.com> wrote: > > > Thanks Geoff, I did not have a setup to verify again, I just brought > one up > > and that failure was a false alarm. Dedicate vlan range test passed in > the > > next run. > > > > > > So, it is a +1 from my side > > > > > > Sent from HTC > > > > > > > > > ----- Reply message ----- > > > From: "Geoff Higginbottom" <geoff.higginbot...@shapeblue.com> > > > To: "dev@cloudstack.apache.org" <dev@cloudstack.apache.org> > > > Subject: [VOTE] Apache CloudStack 4.3.0 (fifth round) > > > Date: Tue, Feb 18, 2014 5:11 AM > > > > > > > > > > > > I've update the Jira ticket with the following comment: > > > > > > I have tried to reproduce this manually and have not been able to re- > > create the issue. Added a new Guest VLAN Range in addition to the > existing > > range, then dedicated to a normal user account, all successful, and all > on the > > latest RC (fifth round). > > > > > > Regards > > > > > > Geoff Higginbottom > > > > > > D: +44 20 3603 0542 | S: +44 20 3603 0540 | M: +447968161581 > > > > > > geoff.higginbot...@shapeblue.com > > > > > > -----Original Message----- > > > From: Srikanteswararao Talluri > > > [mailto:srikanteswararao.tall...@citrix.com] > > > Sent: 17 February 2014 22:29 > > > To: dev@cloudstack.apache.org > > > Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fifth round) > > > > > > There is a new test failure in this RC which is a regression from > > > previous RC. Created a bug for this > > > https://issues.apache.org/jira/browse/CLOUDSTACK-6131 > > > > > > http://jenkins.buildacloud.org/view/cloudstack-qa-4.3/job/test-smoke-m > > > atrix > > > -4.3/1194/suite=test_guest_vlan_range/testReport/integration.smoke.tes > > > t_gue > > > > > st_vlan_range/TestDedicateGuestVlanRange/test_dedicateGuestVlanRange/ > > > > > > > > > > > > > > > On KVM(CentOS 6.3)/Test Run: #1193 > > > -------- > > > 4 of the test failures are not valid because snapshots, scaling VM are > not > > supported on KVM Hypervisor and 5 more intermittent test script/env issue > > related to ssh. > > > 1 failure related to dedicated guest VLAN range looks like a bug > > > ------- > > > Link to reports: > > > http://jenkins.buildacloud.org/job/test-smoke-matrix-4.3/1193/testRepo > > > rt/ > > > > > > -------- > > > Total:98 > > > Fail :10 > > > Skip :2 > > > -------- > > > > > > name pass fail skip > > > test_loadbalance/ 0 4 0 > > > test_guest_vlan_range/ 0 1 0 > > > test_deploy_vms_with_varied_deploymentplanners/ 3 0 0 > > > test_non_contigiousvlan/ 1 0 0 > > > test_reset_vm_on_reboot/ 1 0 0 > > > test_resource_detail/ 1 0 0 > > > test_scale_vm/ 0 1 0 > > > test_ssvm/ 10 0 0 > > > test_network/ 7 0 0 > > > test_disk_offerings/ 3 0 0 > > > test_volumes/ 9 0 0 > > > test_affinity_groups/ 1 0 0 > > > test_routers/ 9 0 0 > > > test_deploy_vm_with_userdata/ 2 0 0 > > > test_network_acl/ 1 0 0 > > > test_vm_life_cycle/ 9 1 0 > > > test_privategw_acl/ 1 0 0 > > > test_internal_lb/ 1 0 0 > > > test_deploy_vm/ 1 0 0 > > > test_global_settings/ 1 0 0 > > > test_nic/ 1 0 0 > > > test_public_ip_range/ 1 0 0 > > > test_iso/ 5 0 1 > > > test_service_offerings/ 4 0 0 > > > test_multipleips_per_nic/ 1 0 0 > > > test_regions/ 1 0 0 > > > test_templates/ 7 0 1 > > > test_vpc_vpn/ 2 0 0 > > > test_vm_snapshots/ 0 3 0 > > > test_portable_publicip/ 2 0 0 > > > test_pvlan/ 1 0 0 > > > -------- > > > > > > > > > On XenServer6.2/Test Run: #1194 > > > -------- > > > 5 failures are intermittent test script/env issues related to ssh and > > > 1 failure in dedicated guest vlan range looks like a bug > > > ------- > > > Link to reports: > > > http://jenkins.buildacloud.org/job/test-smoke-matrix-4.3/1194/testRepo > > > rt/ > > > > > > -------- > > > Total:98 > > > Fail :6 > > > Skip :2 > > > -------- > > > > > > name pass fail skip > > > test_loadbalance/ 3 0 0 > > > test_guest_vlan_range/ 0 1 0 > > > test_deploy_vms_with_varied_deploymentplanners/ 3 0 0 > > > test_non_contigiousvlan/ 1 0 0 > > > test_reset_vm_on_reboot/ 1 0 0 > > > test_resource_detail/ 1 0 0 > > > test_scale_vm/ 1 0 0 > > > test_ssvm/ 10 0 0 > > > test_network/ 7 0 0 > > > test_disk_offerings/ 3 0 0 > > > test_volumes/ 9 0 0 > > > test_affinity_groups/ 1 0 0 > > > test_routers/ 9 0 0 > > > test_deploy_vm_with_userdata/ 2 0 0 > > > test_network_acl/ 1 0 0 > > > test_vm_life_cycle/ 9 1 0 > > > test_privategw_acl/ 1 0 0 > > > test_internal_lb/ 1 0 0 > > > test_deploy_vm/ 1 0 0 > > > test_global_settings/ 1 0 0 > > > test_nic/ 1 0 0 > > > test_public_ip_range/ 1 0 0 > > > test_iso/ 5 0 1 > > > test_service_offerings/ 4 0 0 > > > test_multipleips_per_nic/ 1 0 0 > > > test_regions/ 1 0 0 > > > test_templates/ 7 0 1 > > > test_vpc_vpn/ 2 0 0 > > > test_vm_snapshots/ 0 4 0 > > > test_portable_publicip/ 2 0 0 > > > test_pvlan/ 1 0 0 > > > -------- > > > > > > Thanks, > > > ~Talluri > > > > > > > > > > > > > > > On 17/02/14 10:57 am, "Animesh Chaturvedi" > > > <animesh.chaturv...@citrix.com> > > > wrote: > > > > > >>+1 (binding) verified release artifacts, tested with devcloud. > > >> > > >>Thanks > > >>Animesh > > >> > > >>On Feb 13, 2014, at 10:25 PM, "Animesh Chaturvedi" > > >><animesh.chaturv...@citrix.com> wrote: > > >> > > >>> > > >>> > > >>> > > >>> Hi All, > > >>> > > >>> > > >>> > > >>> I've created a 4.3.0 release, with the following artifacts up for a > > >>> > > >>> vote: > > >>> > > >>> > > >>> > > >>> Given that we have had multiple RC rounds with community testing a > > >>>few times, I would like to close out this VOTE little sooner by > > >>>Tuesday morning PST. > > >>> > > >>> > > >>> > > >>> Git Branch and Commit SH: > > >>> > > >>> > > >>>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h > > >>>= > > >>>ref > > >>>s/heads/4.3 > > >>> Commit: adf4dd59270917b1607940d7064748bd438cbbcc > > >>> > > >>> > > >>> > > >>> List of changes: > > >>> > > >>> New Features in 4.3: > > >>>https://issues.apache.org/jira/issues/?filter=12325248 > > >>> > > >>> Improvement in 4.3: > > >>>https://issues.apache.org/jira/issues/?filter=12325249 > > >>> > > >>> Issues fixed in 4.3 > > >>>https://issues.apache.org/jira/issues/?filter=12326161 > > >>> > > >>> Known Issues in 4.3: > > >>>https://issues.apache.org/jira/issues/?filter=12326162 > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> Source release (checksums and signatures are available at the same > > >>> > > >>> location): > > >>> > > >>> https://dist.apache.org/repos/dist/dev/cloudstack/4.3.0/ > > >>> > > >>> > > >>> > > >>> PGP release keys (signed using 94BE0D7C): > > >>> > > >>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS > > >>> > > >>> > > >>> > > >>> Testing instructions are here: > > >>> > > >>> > > >>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+test+ > > p > > >>>r > > >>>oce > > >>>dure > > >>> > > >>> > > >>> > > >>> Vote will be open for 72 hours (Tuesday morning PST) > > >>> > > >>> > > >>> > > >>> For sanity in tallying the vote, can PMC members please be sure to > > >>>indicate "(binding)" with their vote? > > >>> > > >>> > > >>> > > >>> [ ] +1 approve > > >>> > > >>> [ ] +0 no opinion > > >>> > > >>> [ ] -1 disapprove (and reason why) > > >>> > > >>> > > > > > > Need Enterprise Grade Support for Apache CloudStack? > > > Our CloudStack Infrastructure Support<http://shapeblue.com/cloudstack- > > infrastructure-support/> offers the best 24/7 SLA for CloudStack > > Environments. > > > > > > Apache CloudStack Bootcamp training courses > > > > > > **NEW!** CloudStack 4.2.1 > > > training<http://shapeblue.com/cloudstack-training/> > > > 18th-19th February 2014, Brazil. > > > Classroom<http://shapeblue.com/cloudstack-training/> > > > 17th-23rd March 2014, Region A. Instructor led, > > > On-line<http://shapeblue.com/cloudstack-training/> > > > 24th-28th March 2014, Region B. Instructor led, > > > On-line<http://shapeblue.com/cloudstack-training/> > > > 16th-20th June 2014, Region A. Instructor led, > > > On-line<http://shapeblue.com/cloudstack-training/> > > > 23rd-27th June 2014, Region B. Instructor led, > > > On-line<http://shapeblue.com/cloudstack-training/> > > > > > > This email and any attachments to it may be confidential and are > intended > > solely for the use of the individual to whom it is addressed. Any views > or > > opinions expressed are solely those of the author and do not necessarily > > represent those of Shape Blue Ltd or related companies. If you are not > the > > intended recipient of this email, you must neither take any action based > > upon its contents, nor copy or show it to anyone. Please contact the > sender > > if you believe you have received this email in error. Shape Blue Ltd is a > > company incorporated in England & Wales. ShapeBlue Services India LLP is > a > > company incorporated in India and is operated under license from Shape > > Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in > > Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a > > registered trademark. > > > > > > > > -- > > Daan >
