-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18358/
-----------------------------------------------------------
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Repository: cloudstack-git
Description
-------
- Refactor tests:
- Upgrade tests to use jUnit4
- Break big tests in small unit tests
- Replace assertTrue/False with complex conditions by assertThat with
specific matchers
- Remove dead code:
- Private static method never called locally
- Add test for method that validates CIDRs
Diffs
-----
utils/src/com/cloud/utils/net/NetUtils.java c22e39a
utils/test/com/cloud/utils/net/NetUtilsTest.java d3e283c
Diff: https://reviews.apache.org/r/18358/diff/
Testing
-------
Ran all the tests in the test class before and after refactoring.
Thanks,
Miguel Ferreira
