-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18413/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-6158
https://issues.apache.org/jira/browse/CLOUDSTACK-6158
Repository: cloudstack-git
Description
-------
Added few changes as mentioned under CLOUDSTACK-6158 as below.
1. There is no way to delete a data center created earlier. Added a new
DeleteDataCenter Interface to delete the earlier created datacenter. If user
wants to delete a datacenter created and recreate, deleting has to be manual
earlier. With this change, he can delete a data center created earlier. It will
be useful at many places for testing to destroy and recreate with new settings
etc.
2. when deploy data center runs, it does not adequately verifies whether a
given entry is created or not, it just continues. Added checks to see if an
entry is not successful, it reports, dumps to log and exit gracefully.
3. DataCenter creation as Transaction : At any given point of time during
deploy data center, if an issue happens half way through, earlier created
entries were still available in CS, it wont clean up i.e., data center is half
created, Again, if tried to recreate , the earlier existing entries wont allow
to recreate. Now, data center works as transaction, either all entries are
created as part of data center or none, added a clean up to delete the half
created data center.
4. Export the created Data Center so that user can use it to further delete the
data center with these exported entries etc.
Diffs
-----
tools/marvin/marvin/cloudstackConnection.py ee1ff00
tools/marvin/marvin/cloudstackTestClient.py adb7ce3
tools/marvin/marvin/deployDataCenter.py bf4b688
tools/marvin/marvin/marvinLog.py 80120c9
tools/marvin/marvin/marvinPlugin.py e6986cc
Diff: https://reviews.apache.org/r/18413/diff/
Testing
-------
Tested deleting deploy dc scenarios.
Tested deploy and clean up if an issue occurs.
Thanks,
Santhosh Edukulla