-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17995/
-----------------------------------------------------------
(Updated Feb. 26, 2014, 8:34 a.m.)
Review request for cloudstack and Girish Shilamkar.
Changes
-------
Adding the correct patch file.
Bugs: CLOUDSTACK-6164
https://issues.apache.org/jira/browse/CLOUDSTACK-6164
Repository: cloudstack-git
Description
-------
Currently,Host class has a create method, uses addHost Command, but
1. It does not verify the output of addHost command is valid output in all
forms.
2. Tests some times directly goes to using Host post Host.create, but we are
not sure whether the host is up or not, they have to explicitly call again
listHosts api call, so every where host is added list host is called. Instead,
the create method now returns the FAILED or host object based upon the api
success and whether the host is up.
3. Added a try\except block and return FAILED to tests in case of an exception.
Diffs
-----
tools/marvin/marvin/config/test_data.py PRE-CREATION
tools/marvin/marvin/deployDataCenter.py c8feaaf
Diff: https://reviews.apache.org/r/17995/diff/
Testing
-------
Tested indentation and import changes.
File Attachments (updated)
----------------
Attached wrong file. Adding correct file
https://reviews.apache.org/media/uploaded/files/2014/02/26/ca183e80-434c-4750-876c-fb4b6a377201__0001-Added-fix-for-CLOUDSTACK-6164.patch
Thanks,
Santhosh Edukulla
