> On March 4, 2014, 11:35 p.m., ASF Subversion and Git Services wrote: > > Commit 444e8f6bb3447a7eeb97f7c5d9b46abba3150072 in cloudstack's branch > > refs/heads/4.3-forward from Alena Prokharchyk > > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=444e8f6 ] > > > > CLOUDSTACK-5872: use List DS for storing NicProfiles as public network can > > have more than one nic > >
is this really related to CLOUDSTACK-5872 or is it a typo - daan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17591/#review36192 ----------------------------------------------------------- On Jan. 31, 2014, 2:51 p.m., David Grizzanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17591/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2014, 2:51 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-5872 > https://issues.apache.org/jira/browse/CLOUDSTACK-5872 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-5872: Async response from addAccountToProject doesn't contain > useful information > > Updated the following classes to return a project object after async jobs > complete: > api/src/com/cloud/projects/ProjectService.java | 6 ++-- > .../user/account/AddAccountToProjectCmd.java | 7 +++-- > .../user/account/DeleteAccountFromProjectCmd.java | 7 +++-- > .../user/project/UpdateProjectInvitationCmd.java | 8 +++-- > server/src/com/cloud/projects/ProjectManager.java | 2 +- > .../src/com/cloud/projects/ProjectManagerImpl.java | 34 > +++++++++++----------- > .../com/cloud/projects/MockProjectManagerImpl.java | 16 +++++----- > > Previously these API commands only returned "success => true" in the aysnc > job result. Now it returns the project that a user was added/deleted to. > > > Diffs > ----- > > api/src/com/cloud/projects/ProjectService.java dc882ef > > api/src/org/apache/cloudstack/api/command/user/account/AddAccountToProjectCmd.java > 36df579 > > api/src/org/apache/cloudstack/api/command/user/account/DeleteAccountFromProjectCmd.java > f6aa36c > > api/src/org/apache/cloudstack/api/command/user/project/UpdateProjectInvitationCmd.java > dda7b54 > server/src/com/cloud/projects/ProjectManager.java f568146 > server/src/com/cloud/projects/ProjectManagerImpl.java 5a0ed1c > server/test/com/cloud/projects/MockProjectManagerImpl.java dc377ff > > Diff: https://reviews.apache.org/r/17591/diff/ > > > Testing > ------- > > Testing done on master. > > > Thanks, > > David Grizzanti > >
