H Alex, I will have a test go at this. Did you monkey test it yourself and did you build and run it with -Dnoredist?
On Sat, Mar 8, 2014 at 7:30 PM, Alex Ough <alex.o...@sungard.com> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17790/ > Review request for cloudstack. > By Alex Ough. > > *Updated March 8, 2014, 6:29 p.m.* > Changes > > Unit tests are added. > > *Repository: * cloudstack-git > Description > > Currently, under the environment of cloudstack with multiple regions, each > region has its own management server running with a separate database, which > will cause data discrepancies when users create/update/delete > domain/account/user data independently in each management server. So to > support multiple regions and provide one point of entry for each customer, > this implementation duplicates domain/account/user information of customers > in one region to all of the regions independently whenever there is any > change. > https://issues.apache.org/jira/browse/CLOUDSTACK-4992https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions > > Testing > > 1. Successfully tested real time synchronization as soon as resources are > created/deleted/modified in one region. > 2. Successfully tested full scans to synchronize resources that were missed > during real time synchronization because of any reasons like network > connection issues. > 3. The tests were done manually and also automatically by randomly generating > changes each region. > > Diffs (updated) > > - api/src/com/cloud/domain/Domain.java (c4755d7) > - api/src/com/cloud/event/EventTypes.java (ec54ea1) > - api/src/com/cloud/user/Account.java (99ef954) > - api/src/com/cloud/user/AccountService.java (a9be292) > - api/src/com/cloud/user/User.java (36e9028) > - api/src/com/cloud/user/UserAccount.java (c5a0637) > - api/src/org/apache/cloudstack/api/ApiConstants.java (14df653) > - api/src/org/apache/cloudstack/api/BaseCmd.java (e869ddf) > - api/src/org/apache/cloudstack/api/response/AccountResponse.java > (b7d30ca) > - api/src/org/apache/cloudstack/api/response/DomainResponse.java > (0c0281e) > - api/src/org/apache/cloudstack/api/response/UserResponse.java > (40e1561) > - api/src/org/apache/cloudstack/region/Region.java (df64e44) > - > engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml > (08efb83) > - engine/schema/src/com/cloud/domain/DomainVO.java (f6494b3) > - engine/schema/src/com/cloud/user/AccountVO.java (fb1b58a) > - engine/schema/src/com/cloud/user/UserAccountVO.java (cef9239) > - engine/schema/src/com/cloud/user/UserVO.java (68879f6) > - engine/schema/src/org/apache/cloudstack/region/RegionVO.java > (608bd2b) > - framework/db/src/com/cloud/utils/db/Attribute.java (82c2bdb) > - framework/db/src/com/cloud/utils/db/GenericDao.java (cb401cd) > - framework/db/src/com/cloud/utils/db/GenericDaoBase.java (cecea84) > - framework/db/src/com/cloud/utils/db/SqlGenerator.java (befe34b) > - > plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java > (7db3073) > - > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java > (fa7be58) > - server/src/com/cloud/api/ApiDispatcher.java (5bdefe7) > - server/src/com/cloud/api/ApiResponseHelper.java (81bfe21) > - server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java (5e087fd) > - server/src/com/cloud/api/query/dao/UserAccountJoinDaoImpl.java > (923a238) > - server/src/com/cloud/api/query/vo/AccountJoinVO.java (8d642ed) > - server/src/com/cloud/api/query/vo/UserAccountJoinVO.java (ed29284) > - server/src/com/cloud/event/ActionEventUtils.java (9724d99) > - server/src/com/cloud/projects/ProjectManagerImpl.java (5a0ed1c) > - server/src/com/cloud/server/StatsCollector.java (548587c) > - server/src/com/cloud/user/AccountManager.java (983caf1) > - server/src/com/cloud/user/AccountManagerImpl.java (186cfb2) > - server/src/com/cloud/user/DomainManager.java (f72b18a) > - server/src/com/cloud/user/DomainManagerImpl.java (b2a478e) > - server/test/com/cloud/user/MockAccountManagerImpl.java (62e7fc8) > - server/test/com/cloud/user/MockDomainManagerImpl.java (7dddefb) > - setup/db/db/schema-430to440.sql (acc7e21) > > View Diff <https://reviews.apache.org/r/17790/diff/> > -- Daan
