> On March 11, 2014, 12:28 p.m., Donal Lafferty wrote: > > 1. How do you guarantee that 'sudo' is never added to scripts created by > > the Script class? See (utils/src/com/cloud/utils/script/Script.java) > > > > 2. How do you version control the .exe? > > > > 3. WiX can be run on Linux in a WINE environment. Could the > > Windowsfication team check whether it would be reasonable to call WiX from > > a Maven POM that does uses WINE if in a Linux environment? This might > > avoid having to checkin a .exe > > Damodar Reddy Talakanti wrote: > 1. The final thing we wanted to do is to convert all shell scripts which > are getting called inside management server(This does not include Agents as > always they run on Linux Environments) to python scripts. For now I > identified the shell scripts those are getting called in side management > server and written python script(s) for them (Still need to write for seed > system template) and calling for only windows environemnt. In the next phase > I will remove OS > checks inside the code and will call python scripts only. > 2. start.exe is generated out of start.bat so version control is on > start.bar actually. > 3. We will check on this. > > Donal Lafferty wrote: > Hi Damodar, > > WRT #2, I don't mean source version control. I was thinking of the > version reported by the .exe E.g windows .exe's often use the pattern > Major.Minor.Build.Revision I want to understand where the version > information on start.exe is coming from. > > Could you point me to the source for start.exe? > > > Damodar Reddy Talakanti wrote: > Hi Donal, > > I was also looking into the specific format of .exe but I could not get > much on that. If you can point me to some link that is good for me. > Actually we have used Quick Batch Compiler to convert to .exe format.
Hi Damodar, If I understand correctly, start.exe is generated from the most recent start.bat using "Quick Batch Compiler". In that case, it would not be appropriate to check in start.exe, because it would be like checking in .class files. Would it be possible to create a Maven task to carry these instructions out, and document setup at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Windowsfication ? WRT running as a Windows Service, you will not see Start/Stop functionality if you register start.exe as a service. The batch file does not expose the hooks that Windows Service Control Manager (SCM) uses to control a service DLL. You start the underlying TomCat as a Windows Service instead, e.g. http://tomcat.apache.org/tomcat-6.0-doc/windows-service-howto.html. Note that the Hyper-V agent implements SCM hooks by subtyping ServiceBase, see http://msdn.microsoft.com/en-us/library/System.ServiceProcess(v=vs.110).aspx Java equivalents are discussed here: http://stackoverflow.com/questions/68113/how-to-create-a-windows-service-from-java-app WRT testing, the feature spec says you are targeting Win2K12R2, which is not the same as Windows8. I would strongly recommend you test the target platform. To save time, why don't you ask if any community members are able to do the checks for you. WRT scripting, how did you seed the systemVM templates? Is there a work around until a python script is available? - Donal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review36773 ----------------------------------------------------------- On March 11, 2014, 12:45 p.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18964/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 12:45 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Chiradeep Vittal. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 > > > Repository: cloudstack-git > > > Description > ------- > > Windowsfication of CloudStack Management Server > > > Diffs > ----- > > scripts/installer/windows/acs.wxs PRE-CREATION > scripts/installer/windows/client.wxs PRE-CREATION > scripts/installer/windows/start.bat PRE-CREATION > scripts/installer/windows/start.exe PRE-CREATION > scripts/vm/systemvm/injectkeys.py PRE-CREATION > server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 > > Diff: https://reviews.apache.org/r/18964/diff/ > > > Testing > ------- > > Tested in Linux environment after changes > Also tested in Windows environment(For now tested on windows-8) to make sure > it is getting installed and management service is running. > > Able to add zones, able to register templates, able to launch a VM when it is > running on windows. > > Currently though it is getting added as a windows service, not able to start > the service through windows service control manager which I am looking into > currently. When run .exe file which is installed then server is getting up > and able to access cloud stack UI. > > For now The following assumptions are made: > 1. SSH keys are already installed > 2. JAVA is already installed > 3. tomcat is already installed > > This patch contains the following new files related to WiX tool (To compile > and run we need this tool) > 1. acs.wxs > The following command will be used to compile > "<Path To WiX Tool>\bin\candle.exe" acs.wxs > 2. client.wxs > The following command will be used to generate the above file > "<Path To WiX Tool>\bin\heat" dir client -gg -cg Test -ke -sfrag > -template fragment -out client.wxs -var wix.SourceClient -dr WEBAPPS > The following command will be used to compile the above generated file > "<Path To WiX Tool>\bin\candle.exe" client.wxs > 3. The following command will be used to generate .msi file > "<Path To WiX Tool>\bin\light.exe" acs.wixobj client.wixobj -out > acs.msi -ext "C:\Program Files (x86)\WiX Toolset > v3.8\bin\WixUIExtension.dll" -dSourceClient=SourceDir\client > > > Thanks, > > Damodar Reddy Talakanti > >
