Ok so does the last commit edf97ac86c94741ae8964b640bdfc0234929c1e4 is the final one and addresses Alena's concern. I want to rebuild RC if we are good to go
> -----Original Message----- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: Wednesday, March 12, 2014 11:26 AM > To: dev > Subject: Re: [4.3] CLOUDSTACK cidr list length > > H Animesh, > > tyhe other one is for 6232 and I cherrypicked it without recompile, hence the > tabs to spaces commit. > > I am still in discussion with Alena about it. She thinks it is incomplete. It > is > functional for us, but she might be right anyway. > > I don't think it will compile with the trivial one but > f78e7ae51f55da17ed5ba239f99457ee8bc7c4d8 is the blocker (regression) > > > On Wed, Mar 12, 2014 at 7:16 PM, Animesh Chaturvedi > <animesh.chaturv...@citrix.com> wrote: > > I see your this commit + one another > > f78e7ae51f55da17ed5ba239f99457ee8bc7c4d8 for CLOUDSTACK-6232 > > > > That is it right so two commits. > > > > > > There is one more I just saw that is mostly checkstyle fixes > > 0379dbb489b2502b8cf89583afd1a1f3baec93a3 which is trivial > > > >> -----Original Message----- > >> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] > >> Sent: Wednesday, March 12, 2014 9:08 AM > >> To: dev@cloudstack.apache.org > >> Subject: [4.3] CLOUDSTACK cidr list length > >> > >> Animesh, > >> > >> This is one of two production issues that we have. I will be sending > >> you the other one shortly. I was planning to wait till 4.3.1 but that > >> one is a blocker for us. > >> > >> This one is > >> 454cac448d83b973d8cd337cf214b17e31828b93 > >> > >> Thanks, > >> Daan > > > > -- > Daan