----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19036/#review37190 -----------------------------------------------------------
Ship it! Ship It! - Sateesh Chodapuneedi On March 14, 2014, 11:21 a.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19036/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 11:21 a.m.) > > > Review request for cloudstack, Devdeep Singh, Likitha Shetty, Rajesh Battala, > and Sateesh Chodapuneedi. > > > Bugs: CLOUDSTACK-6092 > https://issues.apache.org/jira/browse/CLOUDSTACK-6092 > > > Repository: cloudstack-git > > > Description > ------- > > The feature allows CloudStack admins to define over-provisioning for > individual primary data storages. This will eliminate the tight dependency > over the global parameter to leverage underlying overprovisioning. > admin can update an existing primary store by setting overprovisioning in the > per primary setting. > This value will override the value at the global level. To fall back to the > global value, null value can be passed. > Added overprovisioning as a part of Storage Pool response. > Currently limited to NFS and VMFS data stores. > Appropriate logs added to inform about capacity calculations. > Upgraded setup will migrate the data from data_center_details table to > storage_pool_details > FS : > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+OverProvisioning+as+Per+Primary+Basis > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java 03a4f34 > engine/components-api/src/com/cloud/capacity/CapacityManager.java bd1a610 > server/src/com/cloud/api/query/dao/StoragePoolJoinDaoImpl.java 274bf1c > server/src/com/cloud/capacity/StorageCapacityListener.java 4322ecf > server/src/com/cloud/storage/StorageManagerImpl.java 913dc23 > setup/db/db/schema-430to440.sql 9d41fe9 > test/integration/smoke/test_over_provisioning.py PRE-CREATION > > Diff: https://reviews.apache.org/r/19036/diff/ > > > Testing > ------- > > Build passes successfully. > Rat build for the new file passes. > Patch applies cleanly. > > The following scenarios tested: > setting and resetting of the overprovision factor. > setting the factor to null > adding new data stores > capacity calculations > > New Marvin test: test_over_provisioning.py added > > > Thanks, > > Saksham Srivastava > >
