> On March 13, 2014, 4:55 p.m., Alena Prokharchyk wrote:
> > Also why don't start routers in parallel? First, get all the router nics in 
> > one query like John suggested, then span start process for routers in 
> > separate threads, check the status of each job using Future.

Sure I will do that.


- Saksham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/#review37066
-----------------------------------------------------------


On March 13, 2014, 7:31 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17736/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 7:31 a.m.)
> 
> 
> Review request for cloudstack, John Burwell and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5999
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5999
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> When a guest is rebooted from CloudStack, if the virtual router managing the 
> guest network of that guest is down, CloudStack will not start the virtual 
> router.
> However the router is started in case the guest vm is stopped and then 
> started.
> To mantain similarity between the 2 process it is necessary to start the VR 
> in case it is not running.
> The fix will address the same.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java be00aa8 
> 
> Diff: https://reviews.apache.org/r/17736/diff/
> 
> 
> Testing
> -------
> 
> Testing:
> 1) vm in a single guest network :
>                vm Reboot : If the VR is stopped: VR is first started and then 
> the VM reboots.
>                vm Reboot : If the VR is running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 2)  vm having nics in multi networks :
>                vm Reboot : If VR in any/all network is stopped: VRs are first 
> started and then the VM reboots.
>                vm Reboot : If the VRs are running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 3) vpc :
>                Tested the above scenarios for vpc also, works fine.
> 
> Patch applies cleanly.
> Build passes succesfully.
> FindBug is passed.
> Rebased against latest master.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Reply via email to