----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review37548 -----------------------------------------------------------
plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java <https://reviews.apache.org/r/18677/#comment69146> Please use String.Equals method than '==' plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java <https://reviews.apache.org/r/18677/#comment69147> Why not filter at the source where events gets published it self instead of filtering in the plug-ins? For e.g. in ActionEventUtils.publishOnEventBus you could check the config value 'publish.action.events' and then decide to publish or not. - Murali Reddy On March 4, 2014, 5:51 a.m., Sonal Ojha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18677/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 5:51 a.m.) > > > Review request for cloudstack, Chiradeep Vittal and Murali Reddy. > > > Bugs: CLOUDSTACK-3272 > https://issues.apache.org/jira/browse/CLOUDSTACK-3272 > > > Repository: cloudstack-git > > > Description > ------- > > At present, there are multiple event types that are generated by CS, action > events,usage events, resource state change events and alerts. Current problem > is > all the events gets published on the event bus when event bus is enabled. > Intent is to introduce global setting config parameters to specify which > category of events to be published or not be published on the event bus. > > > Diffs > ----- > > > plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java > 478c8d7 > server/src/com/cloud/configuration/Config.java 2d55f46 > server/src/com/cloud/test/DatabaseConfig.java 9370218 > > Diff: https://reviews.apache.org/r/18677/diff/ > > > Testing > ------- > > Successfully tested publishing / not publishing of various events based on > the global parameter publish.*.events. > > > Thanks, > > Sonal Ojha > >
