----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19695/#review38824 -----------------------------------------------------------
Hey Gabor, for some reason I don't see the icon next to the fields you added isCopyPaste to (api/secret key). I think the diff is missing sprites.png. Can you try creating the patch via git-format-patch -1 <your commit id)? I think it may have been an issue because it was a binary file. - Brian Federle On March 26, 2014, 6:47 p.m., Gabor Apati-Nagy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19695/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 6:47 p.m.) > > > Review request for cloudstack, Brian Federle and Jessica Wang. > > > Bugs: CLOUDSTACK-6227 > https://issues.apache.org/jira/browse/CLOUDSTACK-6227 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6227 (Add copy-paste support for detail view fields): > DetailView widget now supports bool isCopyPaste property that can be set for > fields. If this is set to true, the text of this field is displayed using > ellipsis formatting* and a copy-paste icon is available right next to it. On > clicking this icon, the full text is displayed and auto-selected in > scrollable control so the user can use Ctrl-C or can view the original value. > *: tooltip is also enabled showing the original non-ellipsed value > > > Diffs > ----- > > ui/css/cloudstack3.css 4aab13b > ui/images/sprites.png ee640476efab85e6ec91fd9b09a0ac179f4d259b > ui/scripts/accounts.js aff780e > ui/scripts/ui/widgets/detailView.js 4c5aeea > > Diff: https://reviews.apache.org/r/19695/diff/ > > > Testing > ------- > > > Thanks, > > Gabor Apati-Nagy > >
