> On March 21, 2014, 10:37 a.m., Santhosh Edukulla wrote:
> > test/integration/smoke/test_secondary_storage.py, line 63
> > <https://reviews.apache.org/r/18971/diff/1/?file=515158#file515158line63>
> >
> >     I believe this change is not required, it does not have much impact. 
> >     We are not looking for config existence at other places as well. 
> >     Also, if config does not match for other parameters away from zone, all 
> > those checks are still not existing. These checks are not required in all 
> > tests.

Please close this review, if this change is not required?


- Santhosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18971/#review38083
-----------------------------------------------------------


On March 10, 2014, 4:28 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18971/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 4:28 p.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-6216
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6216
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test case was failing when it is run on an existing setup because the zones 
> would not match with those mentioned in the config file.
> Skipped the test case in this case.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_secondary_storage.py ff9692f 
> 
> Diff: https://reviews.apache.org/r/18971/diff/
> 
> 
> Testing
> -------
> 
> Yes. Ran on an existing setup.
> Log:
> Test system VM start ... SKIP: skip
> Test system templates are ready ... SKIP: Zone in config file not present in 
> setup
> 
> ----------------------------------------------------------------------
> Ran 2 tests in 0.012s
> 
> OK (SKIP=2)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Reply via email to