> On March 9, 2014, 9:08 p.m., John Kinsella wrote: > > Ship It!
John, I noticed the ConsoleProxyInfo file is missing from the commit in 4.3 branch. Can you please add the file, so that it makes it to the maintenance release? Thanks! - Amogh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18759/#review36614 ----------------------------------------------------------- On March 10, 2014, 7:17 p.m., Amogh Vasekar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18759/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 7:17 p.m.) > > > Review request for cloudstack, Demetrius Tsitrelis and John Kinsella. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6204 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6204 > > > Repository: cloudstack-git > > > Description > ------- > > Changes to support HTTP mode in Console Proxy, per > http://www.mail-archive.com/dev@cloudstack.apache.org/msg24151.html , as > realhostip may go away > > More details here : > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Realhost+IP+changes > > > Diffs > ----- > > core/src/com/cloud/info/ConsoleProxyInfo.java > 3439f3d3bfa2e262c48f1d7b1ea4f58522f3fcbe > > engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java > a649bb7212308de70c41e2d74de1d865949f1cb7 > > plugins/storage/image/default/src/org/apache/cloudstack/storage/datastore/driver/CloudStackImageStoreDriverImpl.java > 52cad3bc7af291e59eabc68e23e09248877e0a81 > server/src/com/cloud/configuration/Config.java > 473db96059a4367858f9487d901b7cb3a054654a > server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java > c8769d43349dbc5a3103a00c905f29b7edef0468 > server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java > 611550e90832911fb182ad18d93a8a18333f3a35 > setup/db/db/schema-421to430.sql 39f58d43822ebbe469d9af433582846a80ce91a0 > systemvm/conf/consoleproxy.properties > bb452f5823cb2da2e12aa61d762de90e4349e9ee > > Diff: https://reviews.apache.org/r/18759/diff/ > > > Testing > ------- > > Tested on local environment by > 1. Using HTTP based console proxy > 2. HTTPS with realhostip domain > 3. HTTPS with custom domain and self-signed cert > 4. Secondary storage template download with custom domain and self-signed cert > > > Thanks, > > Amogh Vasekar > >
