Sachchidanand, It helps to find a dev that has been to the code before and add them to the reviewers list. I'll have a quick look to see if I can help.
Daan On Mon, Apr 14, 2014 at 8:19 PM, Sachchidanand Vaidya <vaidy...@juniper.net> wrote: > Hi, > Can someone pls review these changes. > > Thanks & Regards, > Sachin > > On 4/2/14 2:14 AM, "Sachchidanand Vaidya" <vaidy...@juniper.net> wrote: > >> >>----------------------------------------------------------- >>This is an automatically generated e-mail. To reply, visit: >>https://reviews.apache.org/r/19912/ >>----------------------------------------------------------- >> >>Review request for cloudstack. >> >> >>Repository: cloudstack-git >> >> >>Description >>------- >> >>Don't allow service instance creation with empty or null service-instance >>"name" >> >> >>Diffs >>----- >> >> >>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ >>k/contrail/api/command/CreateServiceInstanceCmd.java d2cb4de >> >>Diff: https://reviews.apache.org/r/19912/diff/ >> >> >>Testing >>------- >> >>Unit tested for null and empty "name" parameter. >> >> >>Thanks, >> >>Sachchidanand Vaidya >> > > -- Daan
