Please take a look. ---------- Forwarded message ---------- From: Sonal Ojha <sonal.o...@sungard.com> Date: Tue, Apr 15, 2014 at 6:07 PM Subject: Re: Review Request 18677: CLOUDSTACK-3272 To: Murali Reddy <muralimmre...@gmail.com>, Chiradeep Vittal < chirade...@gmail.com> Cc: Sonal Ojha <sonal.o...@sungard.com>, cloudstack < dev@cloudstack.apache.org>
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ Review request for cloudstack, Chiradeep Vittal and Murali Reddy. By Sonal Ojha. *Updated April 15, 2014, 12:37 p.m.* Changes Removed the earlier not working patch files and added a new patch file (0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch) which works on master with commit 55f53e13e. I could successfully apply the latest patch attached on master and test the alert/action/resource/usage events published on rabbitmq message bus. Earlier patch didnt work as it was built on the older version and had some changes which werent required. Kindly take a look and revert back. *Bugs: * CLOUDSTACK-3272<https://issues.apache.org/jira/browse/CLOUDSTACK-3272> *Repository: * cloudstack-git Description At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Testing Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Diffs - server/src/com/cloud/configuration/Config.java (2d55f46) - server/src/com/cloud/event/ActionEventUtils.java (00122de) - server/src/com/cloud/test/DatabaseConfig.java (9370218) View Diff <https://reviews.apache.org/r/18677/diff/> File Attachments (updated) - Working patch for master (latest git commit 55f53e13e)<https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch> -- *Thanks and Regards,* *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪ www.sungardas. <http://www.sungardas.com/>*in* *[image: Logo]* <http://www.sungardas.com/> *[image: cid:image019.png@01CF48EC.6617C7F0]* <http://blog.sungardas.com/> *[image: cid:image020.png@01CF48EC.6617C7F0]* <http://www.youtube.com/user/SunGardAS> *[image: cid:image021.png@01CF48EC.6617C7F0]*<https://plus.google.com/u/0/102459878242108588663/posts> *[image: cid:image022.png@01CF48EC.6617C7F0]*<https://www.facebook.com/SunGardAS> *[image: cid:image023.png@01CF48EC.6617C7F0]*<http://www.linkedin.com/company/sungard-availability-services> *[image: cid:image024.png@01CF48EC.6617C7F0]*<https://twitter.com/SunGardAS> *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system.
