> On April 16, 2014, 4:02 a.m., Yoshikazu Nojima wrote: > > It seems getHypervisorTypeFromFormat method is only called from > > VolumeJoinDaoImpl#newVolumeResponse. > > It should be fixed, but does it affect snapshot feature? > > Tanner Danzey wrote: > Yes. Without this fix, if you go into the Storage UI panel the volumes > show as OVM without any snapshot button. > > Yoshikazu Nojima wrote: > I understand. Thank you for explanation.
You're most welcome! - Tanner ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20357/#review40494 ----------------------------------------------------------- On April 16, 2014, 3:23 a.m., Tanner Danzey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20357/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 3:23 a.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-5907 and CLOUDSTACK-6396 > https://issues.apache.org/jira/browse/CLOUDSTACK-5907 > https://issues.apache.org/jira/browse/CLOUDSTACK-6396 > > > Repository: cloudstack-git > > > Description > ------- > > Fix for RBD (and potentially CLVM) volumes w/ KVM incorrectly identified as > OVM volumes (not able to snapshot) > > > Diffs > ----- > > server/src/com/cloud/api/ApiDBUtils.java 67e47f7 > > Diff: https://reviews.apache.org/r/20357/diff/ > > > Testing > ------- > > Applied on otherwise clean 4.4 branch and tested in a live testing > environment with KVM hypervisors and RBD primary storage pool that would > otherwise identify as OVM. No errors and no weird behavior. Just the expected > result. > > > Thanks, > > Tanner Danzey > >
