> On April 21, 2014, 6:17 p.m., daan Hoogland wrote: > > did you verify that this works for your use case? Can you add unit tests > > and test scenario?
Test Scenario : Add two vms with two nics each having different networks .Two networks to each vm. One network of each vm have same network configurations (i.e 10.20.30.0/24). One nic of each vm have same ipaddress and one of the nic has portforward rule and try deleting other vm nic throws error saying there is portforward rule assigned. VM1 (nic1,nic2) -> network1,network2. VM2 (nic3,nic4) -> network3,network4. network2 - 10.20.30.0/24 network4 - 10.20.30.0/24 nic2(VM1) ipaddress - 10.20.30.5 nic4(VM2) ipaddress - 10.20.30.5 nic2 has portforward rule defined and trying to to delete nic4 throws message saying there is portforward rule assigned. - upendra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19902/#review40905 ----------------------------------------------------------- On April 2, 2014, 5:09 a.m., upendra moturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19902/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 5:09 a.m.) > > > Review request for cloudstack and Alena Prokharchyk. > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in > another domain has a nic with the same ip and a forwarding rule configured on > it > > > Diffs > ----- > > engine/schema/src/com/cloud/network/rules/dao/PortForwardingRulesDao.java > 4694cb9 > > engine/schema/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java > 45c0aeb > server/src/com/cloud/network/rules/RulesManagerImpl.java 13f6306 > > Diff: https://reviews.apache.org/r/19902/diff/ > > > Testing > ------- > > > Thanks, > > upendra moturi > >
