> On April 22, 2014, 5:55 p.m., Brian Federle wrote: > > Gabor, for the most part the UI is good. However, I did notice the > > 'provider' fields on 'add VPC offering' are just simple text fields, > > instead of dropdowns -- is this intentional? > > Gabor Apati-Nagy wrote: > Thanks for reviewing. Yes this is intentional. On that screen, we allow > only VpcVirtualRouter for all services except Connectivity that has 3 > providers available.
Thanks Gabor. The only modification to make then is to add the readonly="readonly" attribute to the input box, assuming the user cannot change this value. - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41038 ----------------------------------------------------------- On April 15, 2014, 10:41 p.m., Gabor Apati-Nagy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20391/ > ----------------------------------------------------------- > > (Updated April 15, 2014, 10:41 p.m.) > > > Review request for cloudstack, Brian Federle and Jessica Wang. > > > Bugs: CLOUDSTACK-6255 > https://issues.apache.org/jira/browse/CLOUDSTACK-6255 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing > enabled VPC and stretched L2 neworks (ui for SDN) > (UI for SDN) > > > Diffs > ----- > > client/WEB-INF/classes/resources/messages.properties bfa9600 > ui/dictionary.jsp f4d380c > ui/scripts/configuration.js ba6bdce > ui/scripts/docs.js df4bcf0 > ui/scripts/network.js 6494704 > ui/scripts/regions.js 66dae8c > ui/scripts/ui/dialog.js 50e12f9 > ui/scripts/vpc.js 73d34df > > Diff: https://reviews.apache.org/r/20391/diff/ > > > Testing > ------- > > > Thanks, > > Gabor Apati-Nagy > >