----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20703/#review41694 -----------------------------------------------------------
Ship it! Applied to 4.3. Patch doesn't apply to master/4.4-forward, please create a new one. - Koushik Das On April 28, 2014, 10:23 a.m., Rajani Karuturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20703/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 10:23 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, Ian Duffy, and Koushik Das. > > > Bugs: CLOUDSTACK-6509 > https://issues.apache.org/jira/browse/CLOUDSTACK-6509 > > > Repository: cloudstack-git > > > Description > ------- > > importing multiple ldap users to the same cloudstack account fails with > message account already exists. > > > Diffs > ----- > > api/src/com/cloud/user/AccountService.java 8153a3f > > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java > 195e932 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java > 0878410 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java > 5e724e8 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy > a66da1f > server/src/com/cloud/user/AccountManagerImpl.java d367653 > server/test/com/cloud/user/MockAccountManagerImpl.java 38cc1a84 > ui/scripts/accountsWizard.js 6b4907c > > Diff: https://reviews.apache.org/r/20703/diff/ > > > Testing > ------- > > manually tested. added unittests whereever possible. > > > Thanks, > > Rajani Karuturi > >
