> On May 5, 2014, 5:53 a.m., ASF Subversion and Git Services wrote: > > Commit d81c5c44f112df8c0e4388e9d88300b24eefe3d0 in cloudstack's branch > > refs/heads/4.4-forward from Girish Shilamkar > > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d81c5c4 ] > > > > Revert "CLOUDSTACK-6257: Adding function to check state of VM" > > > > This reverts commit 1be8b87fb7fb0203464ac4c66596008855ac5041. > >
Hi Girish, Why was this commit not reverted from master branch. If it was not reverted was there a fix for this patch in master? - sanjeev ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19399/#review42119 ----------------------------------------------------------- On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19399/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 10:41 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-6257 > https://issues.apache.org/jira/browse/CLOUDSTACK-6257 > > > Repository: cloudstack-git > > > Description > ------- > > As suggested, added getState method for VirtualMachine class, and it is > called before template creation. If VM fails to go into desired state, it > returns failure. > > > Diffs > ----- > > tools/marvin/marvin/codes.py 28e907c > tools/marvin/marvin/lib/base.py d753098 > > Diff: https://reviews.apache.org/r/19399/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Ashutosh Kelkar > >
