----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20316/#review42477 -----------------------------------------------------------
test/integration/component/test_ps_domain_limits.py <https://reviews.apache.org/r/20316/#comment76285> Also, we can do a quick code walkthrough to understand the flow. It will help to do it more thoroughly. We can do a gtm. tools/marvin/marvin/lib/common.py <https://reviews.apache.org/r/20316/#comment76280> Please dont add asserts to lib functions, just check the output in test code and take it accordingly. tools/marvin/marvin/lib/common.py <https://reviews.apache.org/r/20316/#comment76283> Please remove asserts from libs. tools/marvin/marvin/lib/common.py <https://reviews.apache.org/r/20316/#comment76284> This function is not required, its like a library on top of one more. We can directly check in test code only. Already, the function getUserApiClient, does returns the success\fail status. tools/marvin/marvin/lib/common.py <https://reviews.apache.org/r/20316/#comment76281> Can we move this function inside Snapshot class only? tools/marvin/marvin/lib/common.py <https://reviews.apache.org/r/20316/#comment76282> This as well can be added to base.py. Maintaining too much common functions dependent upon base.py libraries is current overhead, VirtualMachine_obj.getState(args) can give us is expunged or stopped or started etc. - Santhosh Edukulla On April 24, 2014, 5:31 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20316/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 5:31 p.m.) > > > Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-1466 > https://issues.apache.org/jira/browse/CLOUDSTACK-1466 > > > Repository: cloudstack-git > > > Description > ------- > > Adding test suits in Primary Storage Limits test cases. > 1)Root/Domain admin limits > 2)Domain Limits > 3)Resize volume > 4)Project Limits > 5)Maximum Limits > > > Diffs > ----- > > test/integration/component/test_ps_domain_limits.py PRE-CREATION > test/integration/component/test_ps_limits.py PRE-CREATION > test/integration/component/test_ps_max_limits.py PRE-CREATION > test/integration/component/test_ps_project_limits.py PRE-CREATION > test/integration/component/test_ps_resize_volume.py PRE-CREATION > tools/marvin/marvin/codes.py 4d44c58 > tools/marvin/marvin/lib/base.py d753098 > tools/marvin/marvin/lib/common.py 8868d2d > > Diff: https://reviews.apache.org/r/20316/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Gaurav Aradhye > >