----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21901/ -----------------------------------------------------------
(Updated May 27, 2014, 10:58 a.m.) Review request for cloudstack and Brian Federle. Changes ------- This patch is created with below 2 commit diffs. 1) commit 0a1b98b1a9f715e91eaa4635c02374434da6d6ac Author: vetrivelc <vetrivel.chinnas...@citrix.com> Date: Tue May 27 13:21:04 2014 +0530 L10N:002-Fixed hardcoding issues Signed-off-by: vetrivelc <vetrivel.chinnas...@citrix.com> 2) commit 987bd92922dd8c1e4138e9e31b53ba3dfae81a29 Author: vetrivelc <vetrivel.chinnas...@citrix.com> Date: Fri May 23 21:48:30 2014 +0530 Fixed the hardcoding issues Signed-off-by: vetrivelc <vetrivel.chinnas...@citrix.com> Repository: cloudstack-git Description ------- Externalized the hard coded strings in JavaScript files and added them to messages.properties files. Also appended the link dictionary.jsp with the externalized strings. Diffs ----- client/WEB-INF/classes/resources/messages.properties eff2c3e systemvm/js/cloud.logger.js 751627e ui/dictionary.jsp 9cc030a ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a ui/scripts/accounts.js a789084 ui/scripts/configuration.js 1a88224 ui/scripts/events.js 2731cb6 ui/scripts/network.js f934f21 ui/scripts/sharedFunctions.js 2cfc89f ui/scripts/storage.js 2660aa5 ui/scripts/system.js 67e01f1 ui/scripts/templates.js 67cc2fb ui/scripts/ui-custom/physicalResources.js 06fcca7 ui/scripts/ui-custom/regions.js 986e009 ui/scripts/ui/dialog.js 34cec7b ui/scripts/ui/widgets/listView.js be40d33 ui/scripts/vpc.js 020b9d7 Diff: https://reviews.apache.org/r/21901/diff/ Testing ------- Tested in local environment by replacing the fixed file. File Attachments (updated) ---------------- Patch - 2 Commits https://reviews.apache.org/media/uploaded/files/2014/05/27/4d2b3c2f-246b-49a6-a528-8c95eecbfba8__001002-L10N-Hardcoding_Fix.patch Thanks, Vetrivel Chinnasamy
