I am alright with the ability to turn it off, preferably at run time. On Fri, May 30, 2014 at 8:20 PM, Nitin Mehta <nitin.me...@citrix.com> wrote: > Hey Daan, > In the thread we have discussed the merits and demerits of having this. > IMHO, I am not convinced why we should have this but very concerned that > the downsides includes performance of apis, unnecessary clutter in the > logs etc. Its evident that not every one wants this ability. There should > be at the minimum ability to turn off this worker. Let me know if you > agree. > > Thanks, > -Nitin > > On 29/05/14 10:30 AM, "Daan Hoogland" <daan.hoogl...@gmail.com> wrote: > >>If removing the worker means that unknown parameters are never logged >>i am -1 removing it. >> >>On Thu, May 29, 2014 at 7:25 PM, Nitin Mehta <nitin.me...@citrix.com> >>wrote: >>> Antonio - Can you please remove this worker ? I had filed a bug >>> https://issues.apache.org/jira/browse/CLOUDSTACK-6658 for the same >>> >>> Thanks, >>> -Nitin >>> >>> On 29/05/14 5:06 AM, "Santhosh Edukulla" <santhosh.eduku...@citrix.com> >>> wrote: >>> >>>>We still see "Unknown parameters..." huge number of logs in server log. >>>>May be, we can make this as configurable or dump to some other log say >>>>misc log, >>>> >>>>if mandatory params are not sent as per request, dump to the log and >>>>return, >>>>if arg types and arguments as per validation are wrong, then dump. But >>>>dumping every unknown param, real issues get lost with these huge log >>>>set rolling when debugging. >>>> >>>>Regards, >>>>Santhosh >>>>________________________________________ >>>>From: Nitin Mehta [nitin.me...@citrix.com] >>>>Sent: Monday, May 19, 2014 2:42 AM >>>>To: Antonio Fornié Casarrubios; cloudstack >>>>Subject: Re: seeing "Unknown parameters : ctxdetails" for >>>>addResourceDetail/removeResourceDetail >>>> >>>>Thanks Anotnio. That’s what I have been saying from the beginning. >>>>IMHO, >>>>I don’t see much value in having this, but I am really concerned with >>>>the >>>>performance of the apis especially in production setups. >>>>For this reason can we please remove this worker or at the very least >>>>have a setting to not have it turned on by default ? >>>> >>>>-Nitin >>>> >>>>From: Antonio Fornié Casarrubios >>>><antonio.for...@gmail.com<mailto:antonio.for...@gmail.com>> >>>>Date: Sunday 18 May 2014 4:22 PM >>>>To: cloudstack >>>><dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>> >>>>Cc: Nitin Mehta <nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>> >>>>Subject: Re: seeing "Unknown parameters : ctxdetails" for >>>>addResourceDetail/removeResourceDetail >>>> >>>> >>>>If the parameter is correct then it should not be in the logs as >>>>unknown. >>>>And so it should be added to the worker in the list of parameters that >>>>the worker will never blame. That is the fix. Right? >>>> >>>>Perhaps it is not considered good that everytime a new parameter is >>>>added >>>>to the api requests it has to be included in the worker. In that case >>>>then perhaps it's better to just completely remove the worker itself. >>>> >>>>Thansk, cheers >>>>Antonio >>>> >>>>El 16/05/2014 23:21, "Min Chen" >>>><min.c...@citrix.com<mailto:min.c...@citrix.com>> escribió: >>>>Ctxdetails complained in your warning log is one of internal parameters >>>>added by ApiDispatcher, and is not publicly presented in the API Cmd >>>>class. For those parameters, they are not errors in the request and >>>>nothing to be fixed. >>>> >>>>Thanks >>>>-min >>>> >>>>On 5/14/14 12:46 AM, "Antonio Fornié Casarrubios" >>>><antonio.for...@gmail.com<mailto:antonio.for...@gmail.com>> wrote: >>>> >>>>>The errors in the requests are created by these well known clients, >>>>>that's >>>>>why they should be fixed. It's not that the admin misspelled a param, >>>>>it's >>>>>more that the code that creates the requests (the js in the web ui, >>>>>cloudmonkey, Marvin or any other...) >>>>> >>>>>Cheers >>>>>antonio >>>>> >>>>> >>>>>2014-05-14 3:05 GMT+02:00 Nitin Mehta >>>>><nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>>: >>>>> >>>>>> Daan - MS logs are visible only to the admin and not a general user. >>>>>>So >>>>>> are you saying this is for admin to debug in case he misspelled a >>>>>>param >>>>>>? >>>>>> >>>>>> I feel that this shouldn’t be ON by default and whether such logic >>>>>>should >>>>>> be part of CS core ? >>>>>> I also find it difficult to understand that in production the admin >>>>>>would >>>>>> commit such basic mistakes. I am assuming that he/she would be a >>>>>>power >>>>>> user and would be using well known clients - say cmd line or UI to >>>>>>fire >>>>>> apis against CS. >>>>>> >>>>>> Thanks, >>>>>> -Nitin >>>>>> >>>>>> On 13/05/14 1:58 PM, "Daan Hoogland" >>>>>><daan.hoogl...@gmail.com<mailto:daan.hoogl...@gmail.com>> wrote: >>>>>> >>>>>> >It is usefull for users that misspell a parameter and expect >>>>>>behavior >>>>>> >related to it. not just in development. >>>>>> > >>>>>> >On Tue, May 13, 2014 at 7:24 PM, Nitin Mehta >>>>>><nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>> >>>>>> >wrote: >>>>>> >> I introduced the parameter ctxdetails which carries all the >>>>>>context >>>>>> >> details (currently all the first class entities and their >>>>>>corresponding >>>>>> >> interface mapping). >>>>>> >> This would be done for each of the api and hence seen for all >>>>>>apis. >>>>>> >> >>>>>> >> I saw the code in ParamGenericValidationWorker and will fix this. >>>>>>Filed >>>>>> >>a >>>>>> >> bug CLOUDSTACK-6658 >>>>>> >> But I am curious why we have this code at all ? It checks whether >>>>>>the >>>>>> >> params passed for the api are an exact match (nothing more nothing >>>>>>less) >>>>>> >> to the params we expect and if not throws only a warning as seen >>>>>>below. >>>>>> >> While it might be good for a developer setup it decreases the >>>>>> >>performance >>>>>> >> for production systems I believe. >>>>>> >> >>>>>> >> Thanks, >>>>>> >> -Nitin >>>>>> >> >>>>>> >> On 13/05/14 3:01 AM, "Koushik Das" >>>>>><koushik....@citrix.com<mailto:koushik....@citrix.com>> wrote: >>>>>> >> >>>>>> >>>I am seeing the same for many commands. So this is not specific to >>>>>> >>>add/removeResourceDetail >>>>>> >>> >>>>>> >>>2014-05-09 18:17:39,477 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-24:job-28 ctx-6eaab5d7) Received unknown >>>>>>parameters >>>>>> >>>for >>>>>> >>>command updateNetworkServiceProvider. Unknown parameters : >>>>>>ctxdetails >>>>>> >>>2014-05-09 18:17:42,584 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-25:job-29 ctx-9c9f87f4) Received unknown >>>>>>parameters >>>>>> >>>for >>>>>> >>>command updatePhysicalNetwork. Unknown parameters : ctxdetails >>>>>> >>>2014-05-12 11:13:29,079 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-1:job-3 ctx-146e0b74) Received unknown >>>>>>parameters >>>>>>for >>>>>> >>>command createPhysicalNetwork. Unknown parameters : ctxdetails >>>>>> >>>2014-05-12 11:13:29,188 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-2:job-4 ctx-923175d9) Received unknown >>>>>>parameters >>>>>>for >>>>>> >>>command addTrafficType. Unknown parameters : ctxdetails >>>>>> >>>2014-05-12 11:13:44,521 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-5:job-7 ctx-255c7f04) Received unknown >>>>>>parameters >>>>>>for >>>>>> >>>command configureVirtualRouterElement. Unknown parameters : >>>>>>ctxdetails >>>>>> >>>2014-05-12 11:13:44,576 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-6:job-8 ctx-5bbd3334) Received unknown >>>>>>parameters >>>>>>for >>>>>> >>>command updateNetworkServiceProvider. Unknown parameters : >>>>>>ctxdetails >>>>>> >>>2014-05-12 11:13:49,705 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-7:job-9 ctx-382414ba) Received unknown >>>>>>parameters >>>>>>for >>>>>> >>>command configureVirtualRouterElement. Unknown parameters : >>>>>>ctxdetails >>>>>> >>>2014-05-12 11:13:49,746 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-8:job-10 ctx-e806b020) Received unknown >>>>>>parameters >>>>>>for >>>>>> >>>command updateNetworkServiceProvider. Unknown parameters : >>>>>>ctxdetails >>>>>> >>>2014-05-12 11:13:54,873 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-9:job-11 ctx-6f762490) Received unknown >>>>>>parameters >>>>>>for >>>>>> >>>command configureInternalLoadBalancerElement. Unknown parameters : >>>>>> >>>ctxdetails >>>>>> >>>2014-05-12 11:13:54,917 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-10:job-12 ctx-a9a7f4dd) Received unknown >>>>>>parameters >>>>>> >>>for >>>>>> >>>command updateNetworkServiceProvider. Unknown parameters : >>>>>>ctxdetails >>>>>> >>>2014-05-12 11:14:00,003 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-11:job-13 ctx-434a524d) Received unknown >>>>>>parameters >>>>>> >>>for >>>>>> >>>command updatePhysicalNetwork. Unknown parameters : ctxdetails >>>>>> >>>2014-05-12 17:50:42,708 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-1:job-21 ctx-706223d8) Received unknown >>>>>>parameters >>>>>>for >>>>>> >>>command deployVirtualMachine. Unknown parameters : ctxdetails >>>>>> >>>2014-05-13 14:19:43,496 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-4:job-31 ctx-aff14d23) Received unknown >>>>>>parameters >>>>>>for >>>>>> >>>command deployVirtualMachine. Unknown parameters : ctxdetails >>>>>> >>>2014-05-13 14:48:59,308 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-1:job-53 ctx-9cc47c4f) Received unknown >>>>>>parameters >>>>>>for >>>>>> >>>command startVirtualMachine. Unknown parameters : ctxdetails >>>>>> >>>2014-05-13 14:50:18,255 WARN >>>>>>[c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>(API-Job-Executor-5:job-61 ctx-5ceecd58) Received unknown >>>>>>parameters >>>>>>for >>>>>> >>>command startVirtualMachine. Unknown parameters : ctxdetails >>>>>> >>> >>>>>> >>> >>>>>> >>> >>>>>> >>> >>>>>> >>> >>>>>> >>>On 13-May-2014, at 4:09 AM, Alena Prokharchyk >>>>>> >>>>>>>>><alena.prokharc...@citrix.com<mailto:alena.prokharc...@citrix.com>> >>>>>>wrote: >>>>>> >>> >>>>>> >>>> Hi Antonio, >>>>>> >>>> >>>>>> >>>> I see following errors in the 4.4 logs: >>>>>> >>>> >>>>>> >>>> WARN [c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>>(API-Job-Executor-49:job-2867 ctx-072e9ae9) Received unknown >>>>>>parameters >>>>>> >>>>for command removeResourceDetail. Unknown parameters : ctxdetails >>>>>> >>>> WARN [c.c.a.d.ParamGenericValidationWorker] >>>>>> >>>>(API-Job-Executor-50:job-2868 ctx-35195840) Received unknown >>>>>>parameters >>>>>> >>>>for command addResourceDetail. Unknown parameters : ctxdetails >>>>>> >>>> >>>>>> >>>> Isn¹t something that you¹ve fixed already? If so, what branches >>>>>>did it >>>>>> >>>>go to? If not, can you please fix it? >>>>>> >>>> >>>>>> >>>> Thanks! >>>>>> >>>> Alena. >>>>>> >>> >>>>>> >> >>>>>> > >>>>>> > >>>>>> > >>>>>> >-- >>>>>> >Daan >>>>>> >>>>>> >>>> >>> >> >> >> >>-- >>Daan >
-- Daan
