ok, it does. i am now convinced I changed the right thing and enough. On Wed, Jun 4, 2014 at 5:11 PM, Chip Childers <chipchild...@apache.org> wrote: > On Wed, Jun 04, 2014 at 04:57:18PM +0200, Daan Hoogland wrote: >> Does, but I changed build_asf.sh to create a branch an no longer >> revert. this commit-sh is meant to be the id on my branch then. and it >> is the one we vote on. Not some script that creates another commit. >> >> So in the new situation the release branch x.y keeps the SNAPSHOT at >> all times. In addition an x.y-RC<ccyymmdd>T<hhMM> branch is created >> and a x.y.z tag on the first commit in it. >> >> I have pushed the release attempt I spoke about, so in theory I could >> now send out the VOTE mail containing the commit id (aka commit-sh). >> <-- me sounding sure but actually asking > > I'm struggling to fully understand the comments above, so I'll try to > answer in a specific way: > > The commit-sh that is included in the VOTE email needs to point to the > commit (doesn't matter what branch really) that is (1) being tagged and > (2) the exact contents that are extracted to become the release > artifact. > > Make sense? > > -chip
-- Daan
