> On June 6, 2014, 12:09 p.m., daan Hoogland wrote: > > patch looks alright but it seems to me you have reused a review board entry > > for a second patch. please don't do that. close this one and start a new > > one next time. > > Santhosh Edukulla wrote: > Sure, but reviewboard some times in process throws 5xx error and a given > review request goes in to draft state. Shall i apply a new patch or this > patch be considered for current one? Going ahead, i will take care to apply > with a new one.
I have applied locally and am running a vlidation build. will push when passes. - daan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19874/#review44886 ----------------------------------------------------------- On June 6, 2014, 9:28 a.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19874/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 9:28 a.m.) > > > Review request for cloudstack, daan Hoogland and Kishan Kavala. > > > Bugs: CLOUDSTACK-6793 > https://issues.apache.org/jira/browse/CLOUDSTACK-6793 > > > Repository: cloudstack-git > > > Description > ------- > > 1. Added fix to retrieve the correct domain id for a given accountid. > vm_template table and respective vo, does not have a domain id information. > 2. Added logic to retrieve correct domainid for a given accountid, only when > an invalid domainid is retrieved. Throw an exception in case of invalid > domain id. > 3. Now, creation of tags is getting successful post the fix. > > > Diffs > ----- > > engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd > engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed > server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7 > > Diff: https://reviews.apache.org/r/19874/diff/ > > > Testing > ------- > > Test creation, listing and deletion tags on UserVM ... === TestName: > test_05_vm_tag | Status : SUCCESS === > ok > Test creation, listing and deletion tag on templates ... === TestName: > test_06_template_tag | Status : SUCCESS === > ok > Test creation, listing and deletion tags on ISO ... === TestName: > test_07_iso_tag | Status : SUCCESS === > ok > Test creation, listing and deletion tagson volume ... === TestName: > test_08_volume_tag | Status : SUCCESS === > ok > > > Thanks, > > Santhosh Edukulla > >
