> On June 10, 2014, 7:07 a.m., Koushik Das wrote: > > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java, line > > 5132 > > <https://reviews.apache.org/r/22364/diff/2/?file=605542#file605542line5132> > > > > These methods are getting used by the job framework. Check > > handleVmWorkJob() method in the same java file.
I updated the diff by adding the unused methods. Will start a separate discussion on these - Rajani ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22364/#review45200 ----------------------------------------------------------- On June 10, 2014, 8:24 a.m., Rajani Karuturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22364/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 8:24 a.m.) > > > Review request for cloudstack, daan Hoogland, Kelven Yang, Koushik Das, and > Santhosh Edukulla. > > > Repository: cloudstack-git > > > Description > ------- > > NPEs, unused code or dead code, unwritten field access and self assignment > > > Diffs > ----- > > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java > 25c67db > > Diff: https://reviews.apache.org/r/22364/diff/ > > > Testing > ------- > > > Thanks, > > Rajani Karuturi > >
