----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22232/#review45215 -----------------------------------------------------------
Ship it! for future review requests, please create a bug in issues.apache.org and add it to the review request. - SrikanteswaraRao Talluri On June 10, 2014, 10:09 a.m., Alex Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22232/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 10:09 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > ------- > > test_01_create_volume was expecting the new volume to appears as /dev/sda > when running on KVM (as this is the default volume used in > util.checkVolumeSize), whereas it actually appears as /dev/vdb. > > This patch determines the appropriate volume name in the same way as we do > for XenServer, and uses that instead. > > > Diffs > ----- > > test/integration/smoke/test_volumes.py 73c2722 > > Diff: https://reviews.apache.org/r/22232/diff/ > > > Testing > ------- > > Verified the test now passes when running against a KVM host. > > > Thanks, > > Alex Brett > >
