----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21973/#review45256 -----------------------------------------------------------
Ship it! Ship It! - Santhosh Edukulla On June 10, 2014, 11:16 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21973/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 11:16 a.m.) > > > Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-6780 > https://issues.apache.org/jira/browse/CLOUDSTACK-6780 > > > Repository: cloudstack-git > > > Description > ------- > > Portable IP address was not getting disassociated. Added it to finally block > so that it will get associated always and portable ip range gets cleaned up > properly during cleanup. > > > Diffs > ----- > > test/integration/component/test_portable_ip.py 847bb4a > > Diff: https://reviews.apache.org/r/21973/diff/ > > > Testing > ------- > > Test disassociating portable ip ... === TestName: > test_disassociate_ip_address_no_services | Status : SUCCESS === > ok > Test disassociating portable IP with non-owner account ... === TestName: > test_disassociate_ip_address_other_account | Status : SUCCESS === > ok > Test disassociating portable ip ... === TestName: > test_disassociate_ip_address_services_enabled | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 3 tests in 263.215s > > OK > > > Thanks, > > Ashutosh Kelkar > >
