> On June 12, 2014, 3:56 p.m., Santhosh Edukulla wrote: > > test/integration/smoke/test_deploy_vgpu_enabled_vm.py, line 164 > > <https://reviews.apache.org/r/22512/diff/1/?file=608112#file608112line164> > > > > We have to get nose tests discovery for that. We dont have a case for > > vgpu. > > EX: A tag of advanced,means we want all advanced zone test cases, then > > this test case will as well be picked up otherwise wont if not tagged. > > Similarly, we can do and or with tags values provided separately.
Sorry I don't quite follow you - this test is running in the BVTs at the moment because it is being picked up by the 'basic' and 'advanced' tags, but as there's no vGPU hardware in use it would never work. I suppose we could modify the test to skip if it's not running on vGPU hardware, but that's quite difficult to detect... - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22512/#review45510 ----------------------------------------------------------- On June 12, 2014, 5:21 p.m., Alex Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22512/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 5:21 p.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-6862 and CLOUDSTACK-6876 > https://issues.apache.org/jira/browse/CLOUDSTACK-6862 > https://issues.apache.org/jira/browse/CLOUDSTACK-6876 > > > Repository: cloudstack-git > > > Description > ------- > > - Make this test skip if it's not running on a XenServer host (as that's the > only hypervisor that supports vGPU at present) > - Also remove the tags that make this test run on a BVT, since it will *only* > work if run on a host with vGPU hardware > > See also CLOUDSTACK-6876 - I don't have rights to duplicate these two issues, > but I believe they are the same thing. > > > Diffs > ----- > > test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc > > Diff: https://reviews.apache.org/r/22512/diff/ > > > Testing > ------- > > Tested against a KVM host to ensure the skip logic kicks in. > > > Thanks, > > Alex Brett > >
