----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22452/#review45592 -----------------------------------------------------------
Commit b43036d10e718eea869574780e8ad70b18862b16 in cloudstack's branch refs/heads/master from Anshul Gangwar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b43036d ] CLOUDSTACK-6872: [hyperv] removed the redundant connectToRemote, DisconnectRemote methods which in turn fixes this bug. connectToRemote was used to connect to share, but once the share is domain joined we don't need this method as we already have required permissions - ASF Subversion and Git Services On June 11, 2014, 7:31 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22452/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 7:31 a.m.) > > > Review request for cloudstack, Devdeep Singh and Rajesh Battala. > > > Bugs: CLOUDSTACK-6872 > https://issues.apache.org/jira/browse/CLOUDSTACK-6872 > > > Repository: cloudstack-git > > > Description > ------- > > Removed the redundant connectTORemote method in Hyper-v Agent. We dont't need > this method as share is domain joined so it has all the required permissions. > Removal of this method fixes this bug also. > > > Diffs > ----- > > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs > 0ad95b8 > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs > c8e951e > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs > 372f848 > > Diff: https://reviews.apache.org/r/22452/diff/ > > > Testing > ------- > > tested that volume operations are working fine after removal of this method > > > Thanks, > > Anshul Gangwar > >