> On June 16, 2014, 9:28 p.m., Mike Tutkowski wrote: > > plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java, > > line 1963 > > <https://reviews.apache.org/r/22631/diff/1/?file=610681#file610681line1963> > > > > It looks like in VolumeOrchestrator that the protocol type can be > > "null". > > > > That being the case, I recommend you reverse the order of the "if" > > statement here to be like this: > > > > if (StoragePoolType.NetworkFilesystem.toString().equals(protocoltype)) > > > > This should avoid a NullPointerException if protocoltype is ever 'null'.
thank you. - punith ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22631/#review45762 ----------------------------------------------------------- On June 17, 2014, 2:58 p.m., punith s wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22631/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 2:58 p.m.) > > > Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski. > > > Repository: cloudstack-git > > > Description > ------- > > currently managed storage only supports iscsi protocol. > > hence now adding support for nfs protocol and also resizing the vdi to the SR > size, hence fully utilizing the SR space in managed storage. > > to support nfs, the getNfsSR method's signature has to changed similar to > existing getIscsiSR method. > > SR will be created based on the volume's protocoltype. > > jira id - CLOUDSTACK-6916 > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/DiskTO.java 5901367 > > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java > eea931e > > plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java > 9979802 > server/src/com/cloud/storage/VolumeApiServiceImpl.java 9b034e9 > > Diff: https://reviews.apache.org/r/22631/diff/ > > > Testing > ------- > > system testing done. > > > Thanks, > > punith s > >
