----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22256/#review46267 -----------------------------------------------------------
Ship it! Ship It! - Devdeep Singh On June 20, 2014, 10:21 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22256/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 10:21 a.m.) > > > Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh > Chodapuneedi. > > > Bugs: CLOUDSTACK-6830 > https://issues.apache.org/jira/browse/CLOUDSTACK-6830 > > > Repository: cloudstack-git > > > Description > ------- > > fixed vm migration failing between different clusters if volumes are on zone > primary store. During VM migration, volumes on zone wide primary store > requiring storage migration resulting in failure of VM migration > > This also improves the hostsformigration api. Firstly we were ttrying to > list all hosts and then finding suitable storage pools for all volumes > and then we were checking for whether vm migration requires storage > migration > Now the process is reversed, We are checking for only those volumes which > are not in zone wide primary store and only verifying > that volumes->poolid->clusterid is different from host clusterid and > usesLocal then only it requires storage migration > > > Diffs > ----- > > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java > 4502365 > server/src/com/cloud/server/ManagementServerImpl.java dd4ce0f > > Diff: https://reviews.apache.org/r/22256/diff/ > > > Testing > ------- > > tested following scenarios on my local setup. > 1. VM migration for volumes on zone wide primary store is working fine > 2. VM migration for volumes on cluster wide primary store is working fine > 3. VM migration for volumes on local storage is working fine > > > Thanks, > > Anshul Gangwar > >