Shouldn't the code handle the scenario if vm.password.length is missing from db? In this case the upgrade script will put it but if someone accidentally removes it.
-----Original Message----- From: Nux! [mailto:n...@li.nux.ro] Sent: Thursday, 26 June 2014 2:55 AM To: dev@cloudstack.apache.org Subject: Re: What to modify to increase instance password length? Wunderbar! Thanks guys! -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro ----- Original Message ----- From: "Daan Hoogland" <daan.hoogl...@gmail.com> To: "dev" <dev@cloudstack.apache.org> Sent: Wednesday, 25 June, 2014 8:35:00 PM Subject: Re: What to modify to increase instance password length? pulled both On Wed, Jun 25, 2014 at 9:33 PM, Ian Duffy <i...@ianduffy.ie> wrote: > Yeah sorry, just noticed and fixed it myself. > > > On 25 June 2014 20:32, Daan Hoogland <daan.hoogl...@gmail.com> wrote: > >> yeah, so I should probably get that one in as well? >> >> On Wed, Jun 25, 2014 at 9:28 PM, Ian Duffy <i...@ianduffy.ie> wrote: >> > :( Get them solved? >> > >> > Fixed a styecheck issue in 2bb12f2a85c8497a15cd7b17099aefbd7c486f9b >> needed >> > to remove unused imports. >> > >> > >> > On 25 June 2014 20:24, Daan Hoogland <daan.hoogl...@gmail.com> wrote: >> > >> >> c70cadff0e3d70f625e7160a3aee600a3198cc67 in 4.4 it had conflicts >> >> in the sql:( >> >> >> >> On Wed, Jun 25, 2014 at 8:53 PM, Ian Duffy <i...@ianduffy.ie> wrote: >> >> > Just pushed a change for this to the 4.4-forward branch. >> >> > >> >> > Daan, will you review / cherrypick? >> >> 96412e3e58fd1ced9d269e4552aaa6410bedf556 >> >> > >> >> > Testing done: >> >> > >> >> > Brought up simulator. >> >> > >> >> > Changed password flag for the builtin template. >> >> > >> >> > Brought up VM, password was displayed at length of 6. Stopped >> >> > the VM, >> >> reset >> >> > the password, new password was displayed at length of 6. >> >> > >> >> > Went into global settings, modified the value for >> >> > vm.password.length >> to >> >> 20. >> >> > Restarted the management server. >> >> > Created a new VM, password was displayed at length of 20. >> >> > Stopped the >> VM, >> >> > reset the password, new password was displayed at length of 20. >> >> > >> >> > Thanks, >> >> > >> >> > Ian >> >> > >> >> > On 25 June 2014 18:50, Nux! <n...@li.nux.ro> wrote: >> >> > >> >> >> Volunteer to do it in time for 4.4? >> >> >> >> >> >> Lucian >> >> >> >> >> >> -- >> >> >> Sent from the Delta quadrant using Borg technology! >> >> >> >> >> >> Nux! >> >> >> www.nux.ro >> >> >> >> >> >> >> >> >> ----- Original Message ----- >> >> >> From: "ilya musayev" <ilya.mailing.li...@gmail.com> >> >> >> To: dev@cloudstack.apache.org >> >> >> Sent: Wednesday, 25 June, 2014 6:30:25 PM >> >> >> Subject: Re: What to modify to increase instance password length? >> >> >> >> >> >> You should ask if this can be done as global setting variable - >> >> >> not >> hard >> >> >> coded. >> >> >> >> >> >> This should be an easy one. >> >> >> >> >> >> On 6/25/14, 10:14 AM, Nux! wrote: >> >> >> > I should submit a bug report to rewrite ACS in a scripting >> language. >> >> >> > >> >> >> > Cheers :) >> >> >> > >> >> >> > -- >> >> >> > Sent from the Delta quadrant using Borg technology! >> >> >> > >> >> >> > Nux! >> >> >> > www.nux.ro >> >> >> > >> >> >> > >> >> >> > ----- Original Message ----- >> >> >> > From: "Ian Duffy" <i...@ianduffy.ie> >> >> >> > To: "CloudStack Dev" <dev@cloudstack.apache.org> >> >> >> > Sent: Wednesday, 25 June, 2014 6:11:23 PM >> >> >> > Subject: Re: What to modify to increase instance password length? >> >> >> > >> >> >> > Afaik yes. (Will to be corrected on this but it appears to be >> >> >> > hard >> >> coded) >> >> >> > >> >> >> > >> >> >> > On 25 June 2014 18:06, Nux! <n...@li.nux.ro> wrote: >> >> >> > >> >> >> >> Thanks, Ian, >> >> >> >> >> >> >> >> This means I need to modify the source, rebuild the RPMs and >> update, >> >> >> >> right? (ie it's not something that I can just modify on the >> >> >> >> mgmt >> >> server >> >> >> >> right now). >> >> >> >> >> >> >> >> Lucian >> >> >> >> >> >> >> >> -- >> >> >> >> Sent from the Delta quadrant using Borg technology! >> >> >> >> >> >> >> >> Nux! >> >> >> >> www.nux.ro >> >> >> >> >> >> >> >> >> >> >> >> ----- Original Message ----- >> >> >> >> From: "Ian Duffy" <i...@ianduffy.ie> >> >> >> >> To: "CloudStack Dev" <dev@cloudstack.apache.org> >> >> >> >> Sent: Wednesday, 25 June, 2014 6:02:12 PM >> >> >> >> Subject: Re: What to modify to increase instance password length? >> >> >> >> >> >> >> >> Hi Lucian, >> >> >> >> >> >> >> >> Take a look at >> server/src/com/cloud/server/ManagementServerImpl.java >> >> >> >> >> >> >> >> Line 895 - 898 >> >> >> >> >> >> >> >> @Override >> >> >> >> public String generateRandomPassword() { >> >> >> >> return PasswordGenerator.generateRandomPassword(6); >> >> >> >> } >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> On 25 June 2014 17:16, Nux! <n...@li.nux.ro> wrote: >> >> >> >> >> >> >> >>> Hi guys, >> >> >> >>> >> >> >> >>> Can anyone tell me which changes I should make in order to >> increase >> >> >> >>> password length for instances? >> >> >> >>> Currently I get something like "tK2yptbby" which might have >> >> >> >>> been >> >> secure >> >> >> >> 10 >> >> >> >>> years ago, but now it's way too short. >> >> >> >>> >> >> >> >>> Thanks! >> >> >> >>> Lucian >> >> >> >>> >> >> >> >>> -- >> >> >> >>> Sent from the Delta quadrant using Borg technology! >> >> >> >>> >> >> >> >>> Nux! >> >> >> >>> www.nux.ro >> >> >> >>> >> >> >> >>> >> >> >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> Daan >> >> >> >> >> >> -- >> Daan >> -- Daan
