-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23197/
-----------------------------------------------------------

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7031
    https://issues.apache.org/jira/browse/CLOUDSTACK-7031


Repository: cloudstack-git


Description
-------

The DeployDataCenters class should not call sys.exit directly, instead we now 
raise an exception, which can be handled as required.

In addition this patch tidies up logging by removing calls to print from inside 
the class, and ensures after a successful deploy / remove, we return an exit 
code of 0, rather than the previous behaviour that always returned an exit code 
of 1.


Diffs
-----

  tools/marvin/marvin/deployDataCenter.py c097238 

Diff: https://reviews.apache.org/r/23197/diff/


Testing
-------

Run through pylint, manual testing now in progress to verify functionality...


Thanks,

Alex Brett

Reply via email to