> On April 29, 2014, 12:29 p.m., Santhosh Edukulla wrote: > > Ship It! > > Santhosh Edukulla wrote: > If we don't have any review issues pending, can some body with commit > rights push this patch? > > Santhosh Edukulla wrote: > Saurav, > > Please update BugId and Branch fields. This review submission is pending > since long. Please check. > > Santhosh
santhosh, bug-id is mentioned in the subject CLOUDSTACK-6328 I looked at the bug comments on the bug. changes are already committed by jayapal. But, commit id isnt updated here and the review isnt closed. here is the commit for master https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=96b1c6b saurav, can you mark this review submitted? - Rajani ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20123/#review41708 ----------------------------------------------------------- On April 23, 2014, 9:20 a.m., Saurav Lahiri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20123/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 9:20 a.m.) > > > Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh > Battala, and Santhosh Edukulla. > > > Repository: cloudstack-git > > > Description > ------- > > With multiple java processes writing to the same logfile, each is not aware > of the log4j's internal counter state, this needs to be prevented. So before > starting new java process via the _run.sh , a check is made to ensure that > there are no existing java processes running. This will prevent multiple java > process writing to the same log file namely cloud.out. > > > Diffs > ----- > > systemvm/patches/debian/config/etc/init.d/cloud 83853bc > systemvm/scripts/run.sh 146d96f > systemvm/scripts/utils.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/20123/diff/ > > > Testing > ------- > > Tested the changes with console proxy vm and secondary storage vm. They start > and stop as expected. > > > Thanks, > > Saurav Lahiri > >
