Hi Koushik,

fixed the build for simulator.

I just found out Simulator use its own VOes for some VOes, it may not be easy 
for developer to add feature for simulator if the feature needs to change VO, 
for example, the new VMsync logic, I don't think simulator test the new VMsync 
logic. 

If we consider Simulator as a hypervisor, ideally it should use the same VOes 
as other hypersivors. Can you help us understand what's the reason behind this?

Thanks
Anthony







./plugins/hypervisors/simulator/src/com/cloud/simulator/MockVMVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockSecStorageVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockVolumeVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockStoragePoolVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockHostVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockConfigurationVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockSecurityRulesVO.java





-----Original Message-----
From: Anthony Xu 
Sent: Wednesday, July 30, 2014 10:28 AM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building

We used -Dsimulator to include simulator, it is very easy for developers to 
forget it.  Simulator should be built by default , we may use -Dnosimulator to 
exclude simulator.


Anthony

-----Original Message-----
From: Koushik Das 
Sent: Wednesday, July 30, 2014 3:03 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: RE: Simulator on master is not building

The simulator code should be kept up to date with any changes done in the core 
product. If there are any interface changes, necessary changes should be made 
in simulator plugin as well along with other hypervisor plugins. To build 
simulator code use refer to [1].

-Koushik

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration

-----Original Message-----
From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com] 
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building

I believe for every check-in we decided to run sanity tests on simulator 
atleast, currently build for simulator is failing. 

 ------------------------------------------------------------------------
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation 
failure:
[ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
 error: 'try' without 'catch', 'finally' or resource declarations [ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
 error: 'try' without 'catch', 'finally' or resource declarations


Thanks!
Santhosh

Reply via email to