> On July 31, 2014, 4:19 a.m., Santhosh Edukulla wrote: > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java, > > line 482 > > <https://reviews.apache.org/r/24111/diff/1/?file=646144#file646144line482> > > > > Message info seems to be corrected.
Hi Santhosh, What is fix required here? Thanks & Regards, Ritu. > On July 31, 2014, 4:19 a.m., Santhosh Edukulla wrote: > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java, > > line 561 > > <https://reviews.apache.org/r/24111/diff/1/?file=646144#file646144line561> > > > > Missing try\catch here. But, there is a better way suggested by Daan to > > auto close resources using try-with-resource to avoid any of these usages. I will fix this using try-with-resources. - Ritu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/#review49200 ----------------------------------------------------------- On July 30, 2014, 7:44 p.m., Ritu Sabharwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24111/ > ----------------------------------------------------------- > > (Updated July 30, 2014, 7:44 p.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Bugs: CLOUDSTACK-6823 > https://issues.apache.org/jira/browse/CLOUDSTACK-6823 > > > Repository: cloudstack-git > > > Description > ------- > > Fixed Coverity findings for brocade-plugin > > > Diffs > ----- > > > plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java > 60edbcf > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java > d5f06f8 > > Diff: https://reviews.apache.org/r/24111/diff/ > > > Testing > ------- > > > Thanks, > > Ritu Sabharwal > >
