-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24152/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 10:18 a.m.)
Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
Changes
-------
Rebased with latest master
Bugs: CLOUDSTACK-7182
https://issues.apache.org/jira/browse/CLOUDSTACK-7182
Repository: cloudstack-git
Description
-------
- Check to see if network is implemented changed from 'state ==
Implementing||Implemented' to 'state == Implemented'. The earlier check was a
hack to prevent the issue described next.
- At the time of implementing network (using implementNetwork() method), if the
VR needs to be deployed then it follows the same path of regular VM deployment.
This leads to a nested call to implementNetwork() while preparing VR nics. This
flow creates issues in dealing with network state transitions. The original
call puts network in "Implementing" state and then the nested call again tries
to put it into same state resulting in issues. In order to avoid it,
implementNetwork() call for VR is replaced with below code.
Diffs (updated)
-----
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
cdca839
Diff: https://reviews.apache.org/r/24152/diff/
Testing
-------
Ran isolated network tests using simulator.
Also ran the following VPC test using simulator:
1. created vpc, VR gets started as part of this
2. created network in the vpc
3. deployed vm in network created in step#2
Thanks,
Koushik Das
