Hi Namita, The patch is applied on master. Please close the review ticket.
Thanks, Jayapal On 05-Aug-2014, at 5:57 PM, Jayapal Reddy <jayapalreddy.ur...@citrix.com<mailto:jayapalreddy.ur...@citrix.com>> wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24306/ Ship it! Ship It! - Jayapal Reddy On August 5th, 2014, 10 a.m. UTC, Namita Chaudhari wrote: Review request for cloudstack and Jayapal Reddy. By Namita Chaudhari. Updated Aug. 5, 2014, 10 a.m. Bugs: CLOUDSTACK-2694<https://issues.apache.org/jira/browse/CLOUDSTACK-2694>, https://issues.apache.org/jira/browse/CLOUDSTACK-2694<https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-2694> Repository: cloudstack-git Description CLOUDSTACK-2694 - [Firewall Rule] Able to configure duplicate firewall rule with protocol and no ports When a duplicate firewall rule is created with same cidr, protocol and no ports, an error popup appears for duplicate firewall rule. Testing Testing done based on the test cases updated in the bug. Diffs * server/src/com/cloud/network/firewall/FirewallManagerImpl.java (dd928d8) View Diff<https://reviews.apache.org/r/24306/diff/>
